Activity (RSS)

Also, after verification, the dots ('.') are not needed at the end of the titles with markdown.

Huh, where in the world did I get that idea then, could've swo...

Comment[JL20] - ah, missed that dupe. Corrected.

Here's my review for the Detailed Example Contribution.

Also, after verification, the dots ('.') are not needed at the end of the titles with markdown.

Thell,

• Comment[JL20] should still be fixed IMO. You bunched it with the "how-to" discussion while it's a question of grammar.
  
• As for the 'The tickets with' -vs...

Joce,

Firstly, thank you for the detailed review. Also, please remember this is a Contribution Workflow document to help developers understand the high level vi...

test comment.

Updated the document to remove the 'maintainer' actions and fix a few typos.

(from [a7bb650c82f425d28512bea3a72b5cf911aa5eb7]) Merge branch 'jl/LH-2/fix_crash_user_def_style' into pu

• jl/LH-2/fix_crash_user_def_style: User defined langua...

(from [42754945c03ffb1e5a91ce0c67a37f6ba1023ee7]) User defined languages: fix undefined lang crash.

• User defined languages as well as the separator are added d...

(from [3d87bf2114da1226939c72f0fa5d9c86b5d5a45e]) project files: introduce version info generator

• Modifies all VC 8 & 9 build configurations in the notepadplu...

(from [1259be6372e16a60698e1c49d78247a38502ef0a]) project files: introduce version info generator

• Modifies all VC 8 & 9 build configurations in the notepadplu...

Looks good. Will get it on pu for testing.

Thanks joce!

(from [f87f8f94958c3204dfb7c51fecc3ce35fc3b8888]) User defined languages: fix undefined lang crash.

• User defined languages as well as the separator are added d...

The version generation script has been completed. The writing out of the RC information still remains along with modifying the project files for both Notepad++ ...

The default language when loading back a file with an unknown language association is "Normal Text". We could try a bit harder and guess the type from the file ...

After re-testing several times, I retract my statement. I does indeed look to be working fine.

Works just fine for me on WinXP on 2 different machines.
I've tested both my branch (FixDockingBug) and the community/pu in which it was merged into.

Joce,

This patch does not fix the bug on Win7. Haven't tested on XP yet.

Using a clean debug build I did the following (with only NppExec plugin loaded):

• Start...

(from [75a97c7f10eb94e90c0fe52fbe8bd203b8fde9cd]) Merge branch 'jl/LH-1/fix-docking-bug' into pu

• jl/LH-1/fix-docking-bug: Docking Find in Files: Fixed the hang...

(from [e668a6fc9b8d4afc97588ca60ff294094d763820]) Docking Find in Files: Fixed the hanging bug

• Fixed the hanging bug and at least another less serious bug, whe...

Interesting, it looks like the LH update string grabbed from this commit to update the ticket state even though it is already resolved.

I'll keep a closer eye o...

(from [7c2c5e9cae28ecaee4239a9ec55085861975aa6a]) Notepad_plus_msgs.h: trivial comment corrections

• Looks like some comment blocks where just copied but not cha...

Thanks Dave!

I can confirm Win7 now passes all tests, I haven't tried this build on XP yet to verify it still passes all tests.

(from [5abf9740311f688a2a1e3d5369615fe60f30955f]) Merge branch 'db/LH-4/PathFuncFix' into pu

• db/LH-4/PathFuncFix: Common.cpp: PathXXX functions on Windows 7 fi...

(from [dec005f6c2e4940fd928a8f6fecde3f1441dcde5]) Merge branch 'jl/LH-8/debug-function-guards' into pu

• jl/LH-8/debug-function-guards: Debug function guards: im...