[Bug] N++ hangs on Find in Files
Reported by Jocelyn Legault | October 8th, 2009 @ 12:55 AM | in v1.0.0-rc2
Repro steps:
- Open N++
- Make sure you have at least one document open
- Plugins > NppExec > Show Console Dialog
- Make the NppExec console window "floating" (as opposed to docked)
- From a document, do a find in files (anything)
- Take the "Find results" windows, and "dock" it with the NppExec window (you should have two tabs at the bottom of the floating window).
- Close N++.
- Reopen N++ (you should have the console window still floating, but the not search result one).
- Make sure you have at least one document open
- Dock the console window
- From a document, do a find in files (anything)
- N++ hangs.
Found in:
6fca80c
Comments and changes to this ticket
-
Jocelyn Legault October 8th, 2009 @ 12:56 AM
- Tag changed from “#6fca80c, bug, docking, find_results, hang” to “find_results, hang, _bug, _docking, __#6fca80c”
-
Jocelyn Legault October 8th, 2009 @ 12:57 AM
- Tag changed from “find_results, hang, _bug, _docking, __#6fca80c” to “#6fca80c, docking, find_results, _bug, _hang”
-
Jocelyn Legault October 8th, 2009 @ 01:01 AM
- State changed from “new” to “open”
-
Jocelyn Legault October 8th, 2009 @ 01:05 AM
- Title changed from “Bug: N++ hangs on Find in Files” to “[Bug]: N++ hangs on Find in Files”
-
Jocelyn Legault October 8th, 2009 @ 01:05 AM
- Tag changed from “#6fca80c, docking, find_results, _bug, _hang” to “docking, find_results, _bug, _hang”
-
Jocelyn Legault October 8th, 2009 @ 01:06 AM
- Title changed from “[Bug]: N++ hangs on Find in Files” to “[Bug] N++ hangs on Find in Files”
-
Jocelyn Legault October 8th, 2009 @ 01:33 AM
- Milestone set to “v1.0.0-rc1”
-
-
Jocelyn Legault October 16th, 2009 @ 07:14 PM
Should be done ASAP. And IMO, this is a showstopper for 1.0.0.
Also, why push it to rc3? What happened to rc2?
-
Thell Fowler October 16th, 2009 @ 09:15 PM
- Milestone changed from “v1.0.0-rc1” to “v1.0.0-rc2”
rc2 works, mistype on my end.
-
Jocelyn Legault October 20th, 2009 @ 04:47 PM
- State changed from “open” to “needs_ack”
-
-
Jocelyn Legault October 20th, 2009 @ 08:44 PM
I guess the LH magic did not work. :-/
http://github.com/joce/npp-community/commit/537941c9122dfff9421fa5e...
Pull the entire FixDockingBug branch with it as well. It's fixing heap
corruption issues with the grabber as well and other trivial changes (which
I suppose could be left out in pu until post 1.0.0). -
-
Jocelyn Legault October 20th, 2009 @ 11:04 PM
D'oh. I blame extreme tiredness for the typo! :-)
The function guard stuff should not be there. I don't know how it made it to
this branch. That was separate and should not make it in Master before
1.0.0, as we discussed. -
npp-community October 21st, 2009 @ 05:19 PM
(from [e668a6fc9b8d4afc97588ca60ff294094d763820]) Docking Find in Files: Fixed the hanging bug
- Fixed the hanging bug and at least another less serious bug, where the Find in Files window simply did not appear.
[#1 state:needs_hack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/npp-community/npp-community/commit/e668a6fc9b8d4a... -
Thell Fowler October 21st, 2009 @ 05:19 PM
- State changed from “needs_ack” to “proposed”
- Assigned user changed from “Jocelyn Legault” to “npp-community”
(from [75a97c7f10eb94e90c0fe52fbe8bd203b8fde9cd]) Merge branch 'jl/LH-1/fix-docking-bug' into pu
- jl/LH-1/fix-docking-bug: Docking Find in Files: Fixed the hanging bug Gripper: Remove any modifications post destruction. Docking: Properly initialize docking related structures and classes. Docking manager: Fix typo in comment. Precompiled headers: Include npp_debug.h in debug as a convenience. Notepad_plus creation: _hSelf should not be set during creation. Notepad_plus_msgs.h: trivial comment corrections
[#1 state:proposed responsible:npp-community]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/75a97c7f10eb94... -
Thell Fowler October 21st, 2009 @ 05:44 PM
Joce,
This patch does not fix the bug on Win7. Haven't tested on XP yet.
Using a clean debug build I did the following (with only NppExec plugin loaded):
- Start without debugging
- NppExec -> advanced options -> show console on startup
- NppExec -> show console [console started as undocked]
- Closed N++ and ran again without debugging
- [CTRL-F] word [Find in all open docs]
- Dragged the Find Results window to doc with the NppExec
- Dragged both of them to dock at bottom
- Closed find window
- Closed and restarted (once again without debugging)
- [CTRL-F] word [Find in all open docs]
HANG
-
Jocelyn Legault October 21st, 2009 @ 07:17 PM
Works just fine for me on WinXP on 2 different machines.
I've tested both my branch (FixDockingBug) and the community/pu in which it was merged into. -
Thell Fowler October 21st, 2009 @ 07:32 PM
After re-testing several times, I retract my statement. I does indeed look to be working fine.
-
npp-community October 26th, 2009 @ 04:46 PM
(from [391526c05509f1e156924d13b5647758cc57825a]) Docking Find in Files: Fixed the hanging bug
- Fixed the hanging bug and at least another less serious bug, where the Find in Files window simply did not appear.
[#1 state:needs_hack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/npp-community/npp-community/commit/391526c05509f1... -
Thell Fowler October 26th, 2009 @ 04:46 PM
- State changed from “proposed” to “candidate”
(from [719fa856f3fb075609b842ac644faa805d5ff212]) Merge branch 'jl/LH-1/fix-docking-bug' into next
- jl/LH-1/fix-docking-bug: Docking Find in Files: Fixed the hanging bug Gripper: Remove any modifications post destruction. Docking: Properly initialize docking related structures and classes. Docking manager: Fix typo in comment. Precompiled headers: Include npp_debug.h in debug as a convenience. Notepad_plus creation: _hSelf should not be set during creation.
[#1 state:candidate]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/719fa856f3fb07... -
Thell Fowler November 29th, 2009 @ 06:34 AM
- State changed from “candidate” to “resolved”
(from [1fb443b1fadb00194946568f458d01d8c97a66c4]) Merge branch 'jl/LH-1/fix-docking-bug'
- jl/LH-1/fix-docking-bug: Docking Find in Files: Fixed the hanging bug Gripper: Remove any modifications post destruction. Docking: Properly initialize docking related structures and classes. Docking manager: Fix typo in comment. Precompiled headers: Include npp_debug.h in debug as a convenience. Notepad_plus creation: _hSelf should not be set during creation.
[#1 state:resolved]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/1fb443b1fadb00...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Notepad++ Community Release
People watching this ticket
Jocelyn Legault
npp-community
Tags
Referenced by
-
1
[Bug] N++ hangs on Find in Files
[#1
state:resolved]
-
1
[Bug] N++ hangs on Find in Files
LOL, don't blame the LH magic.... [#1
state:needs_hack].
-
1
[Bug] N++ hangs on Find in Files
[#1
state:needs_hack]
-
1
[Bug] N++ hangs on Find in Files
[#1
state:proposed responsible:npp-community]
-
1
[Bug] N++ hangs on Find in Files
[#1
state:needs_hack]
-
1
[Bug] N++ hangs on Find in Files
[#1
state:candidate]