I updated to the new GTest and GMock (1.4), and I've build both libraries in Debug and Release with both VC8 and VC9.
I've also compiled manually N++CR with VC8...

GTest and GMock compile fine in all configuration, and so does N++CR when linking against the new libs.

Good work! :-)

(from [c839c280b349f137748ae060099ddf8be896225c]) google projects: update to test/mock version 1.4

• Remove dependency of Boost TR1 from VC 8 project since Googl...

This essentially invalidates LH-19 since the 1.4 update includes the side-by-side setup in the Test and Mock, so N++ needed to use it too.

(from [8c111e47b5b9a1f73aba8b037cf4bbf872e43f86]) google projects: update to test/mock version 1.4

• Remove dependency of Boost TR1 from VC 8 project since Googl...

Should read

select the 'Setenv Plugin' for installation.

Corrected

The New job creation step doesn't mention what type of job we should create. - Mentioning ...

(from [363433bf3f22e1d78373dd805777b8d6fd7f0d8e]) NPPCR-HUDSON-BUILD-TESTS.bat: add leakdetect switch

• This patch makes use of the NPPCR leakdetect switch to e...

From the README file

• The following line:

select the 'Hudson Setenv Plugin' for installation.

Should read

select the 'Setenv Plugin' for installation.

As i...

(from [363433bf3f22e1d78373dd805777b8d6fd7f0d8e]) NPPCR-HUDSON-BUILD-TESTS.bat: add leakdetect switch

• This patch makes use of the NPPCR leakdetect switch to e...

This one looks good. However, didn't we discuss we should deal with a few messages in the message pump before exiting? Did you encounter problems in that regard...

While the fix in itself works, I think we could skip the whole dynamic assignation altogether.

I'd go with either:

    TCHAR *generic_fontname[128];
#ifdef UNI...

Quick note: tested loading those 41 language files, only see a ~300ms time diff on the calls to menuID2LangType() calls, with debug version - no wonder I didn't...

std::map implementation uses a tree, and is therefore a O(log(n)) search. Yours is O(n), which is worst. Funnily enough, the current implementation with the sw...

Sune,

However, on my 2GHz laptop, running 5.000.000 iterations of 17 lookups, the original takes ~450ms and my new version ~4200ms. Considering I need ~5mil it...

OTOH there's several examples in the NP++ codebase with large amounts of code duplication - generalizing code results in less codelines and easier maintenance.

...

First: thanks for the feedback, guys.

Jocelyn

Grouping your values by 3's doesn't improve readability, but rather deteriorates it IMO.

Well, the entries don't...

The previous version did also include GTest, but I yanked it out for the version I brought to our depot.
My heart goes to keep them as separate projects, but I ...

I'll be glad to do this. Should we keep two distinct projects (Test and Mock) as submodules, or change to a single Google Mock install since it bundles Google T...

(from [b020bea0056a697a9bc131227d3321838551613e]) ScintillaEditView.cpp: fix createHotSpotFromStyle mem leak

• When a document view is activated that has a hotsp...

There is a memory leak in ScintillaEditView when a hotspot style is present within an activated tab. It needs fixing.

Looks Kosher!

• Code size and line numbers isn't a metric we really do care about. That does not mean we encourage code bloat; However readability, stability, reusability and ...

• Load time using this patch takes 40% longer. Originally tested opening with 10 randomly chosen example files the average jumped from 5.4 to 8.4 seconds average...

(from [4317709c9499ee0e6dca6d81f23da9f430b6c917]) Notepad_plus.cpp: rewrite of menuID2LangType()

• Focusing on readability, ease of extension for new language t...

(from [cd8e23474d39fee53b79c02e34e58de551dedf8d]) Notepad_plus.cpp: rewrite of menuID2LangType()

• Focusing on readability, ease of extension for new language t...

(from [d0195ab4287c594215dc4fb011621817895b94c0]) Notepad_plus.cpp: rewrite of menuID2LangType()

• rewrite for easier maintaining, as well as code&binary size.
• S...

(from [fd4f51ff419233f99056414486585ef8ac73f952]) version generator: handle spaces in paths

• add quotes around the file variables in the generator script for co...

(from [e7a01c48278cd64c92c36ed7df15298a2f6dca3c]) NPPCR-HUDSON-BUILD-TESTS.bat: add leakdetect switch

• This patch makes use of the NPPCR leakdetect switch to e...

(from [8a18547da9b99df3ef55e30f2db9c83a8bf17b8d]) hudson: introduce Hudson job and build script

• Hudson, the continuous integration server, can be easily instal...

(from [e7a01c48278cd64c92c36ed7df15298a2f6dca3c]) NPPCR-HUDSON-BUILD-TESTS.bat: add leakdetect switch

• This patch makes use of the NPPCR leakdetect switch to e...

(from [22f01256987124e26921ff29e7ce4c761ebefc8c]) winmain: add console switch for leak detection

• Add the '-leakdetect' switch to allow for console debugger mem...