Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Sune Marcher

Sune Marcher

Member of 5 projects: npp-community, nppcr_googlemock, nppcr_googletest, ...

Sune Marcher's latest activity

Monday, February 22 2010
36 Notepad_plus.cpp: rewrite of menuID2LangType() was updated in npp-community
  • Sune Marcher
    Sune Marcher commented at 11:52 PM

    Dropping this ticket is probably the best idea, yes.

    And yes, "Rewrite language-related functions" is too vague - what I'm particularly aiming at is L_xx and ID...
Sunday, February 21 2010
36 Notepad_plus.cpp: rewrite of menuID2LangType() was updated in npp-community
  • Sune Marcher
    Sune Marcher commented at 2:49 PM

    I did the test slightly differently - OutputDebugString on entry/exit of the function. Started NP++ with a session including those language files, and then subt...
Friday, February 05 2010
36 Notepad_plus.cpp: rewrite of menuID2LangType() was updated in npp-community
  • Sune Marcher
    Sune Marcher commented at 1:43 AM

    Quick note: tested loading those 41 language files, only see a ~300ms time diff on the calls to menuID2LangType() calls, with debug version - no wonder I didn't...
  • Sune Marcher
    Sune Marcher commented at 12:37 AM

    std::map implementation uses a tree, and is therefore a O(log(n)) search. Yours is O(n), which is worst. Funnily enough, the current implementation with the sw...
Thursday, February 04 2010
36 Notepad_plus.cpp: rewrite of menuID2LangType() was updated in npp-community
  • Sune Marcher
    • State changed from needs_ack to open
    • Assigned user changed from npp-community to Sune Marcher
    by Sune Marcher at 10:02 AM

    First: thanks for the feedback, guys.

    Jocelyn

    Grouping your values by 3's doesn't improve readability, but rather deteriorates it IMO.

    Well, the entries don't...
Wednesday, February 03 2010
36 Notepad_plus.cpp: rewrite of menuID2LangType() was updated in npp-community
Notepad_plus.cpp: rewrite of menuID2L... was committed by Sune Marcher at 12:16 PM
Notepad_plus.cpp: rewrite of menuID2L... was committed by Sune Marcher at 7:19 AM
Notepad_plus.cpp: rewrite of menuID2L... was committed by Sune Marcher at 7:16 AM