Nppcommunity nppcr_googlemock → npp-community 2.0

Comments and changes to this ticket

• 

  Thell Fowler December 12th, 2009 @ 03:26 PM

  (from [3091d7ca9cb686d2779f7946032bc760424fefc3]) project files: make vc8 and 9 libs side-by-side

  • Allowing the different vc version to be built and live side-by-side makes for easier testing by developers using multiple vc compilers. This change makes mock recognize the vc8 and 9 paths of google test as well as place the mock binaries in a appropriate path.

  [#2]

  Signed-off-by: Thell Fowler git@tbfowler.name
  http://github.com/npp-community/nppcr_googlemock/commit/3091d7ca9cb...

• 

  Thell Fowler December 12th, 2009 @ 03:29 PM

  Needs ack (and it looks like we need to add the correct tags for this project to match nppcr)

• 

  Jocelyn Legault February 7th, 2010 @ 05:34 AM

  I just tried it on my machine and it looks just fine.
  A little thing I noticed however that we might want to address (or not): The gmock lib is called gmock.lib for all four configurations (VC8, VC9 in both Debug and Release). However, the gtest lib is called gtest.lib only in release. It's called gtestd.lib in Debug (both VC8 and VC9). I'm thinking since we have our own branch, we could harmonize the gmock and gtest library names. I don't really care which pattern we choose, but it'd be nice if it was uniform. OTOH, it's an issue that's of hte least importance... But since you're updating them, now could be a nice time to take care of that.

  Also, it seems I can't ack for this project! :-)

• 

  Thell Fowler February 12th, 2010 @ 09:30 PM

  That's odd. I'll look into the ack'ing authority issue.

  Re: naming. You're absolutely correct that they should follow the same naming convention. IMO, it would be easier to just use the name proper vs appending a 'd'. They are now side-by-side, so there is no ambiguity created by the name.

• 

  Thell Fowler February 19th, 2010 @ 11:57 PM

  • State changed from “open” to “acked”
  • Assigned user changed from “Thell Fowler” to “npp-community”

  It looks like you had authority to ack, we just hadn't setup the state tags for it. - Resolved

  Proposed and Candidate are not available for Gtest and Mock since we are not using the graduating branches one these projects like we are with npp-community. Acked topics here that have a matching npp-community topic will remain as acked until the npp-community topic makes it to master in the npp-community repo.

• 

  Thell Fowler February 19th, 2010 @ 11:59 PM

  • Milestone set to “npp-community 2.0”
• 

  Thell Fowler February 26th, 2010 @ 03:47 PM

  • Assigned user cleared.
  • State changed from “acked” to “resolved”

  Changeset [554288362b2eaae09723d0aa8cd2b2af18b7df92] by Thell Fowler