Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

side-by-side VC versions of libs

#2

Reported by Thell Fowler · December 7th, 2009 @ 05:46 PM

State: resolved
Milestone: npp-community 2.0
Assigned to: nobody

Activity

  1. Thell Fowler
    Thell Fowler

    (from [3091d7ca9cb686d2779f7946032bc760424fefc3]) project files: make vc8 and 9 libs side-by-side

    • Allowing the different vc version to be built and live side-by-side makes for easier testing by developers using multiple vc compilers. This change makes mock recognize the vc8 and 9 paths of google test as well as place the mock binaries in a appropriate path.

    [#2 side-by-side VC versions of libs]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/nppcr_googlemock/commit/3091d7ca9cb...

    December 12th, 2009 @ 03:26 PM

  2. Thell Fowler
    Thell Fowler

    Needs ack (and it looks like we need to add the correct tags for this project to match nppcr)

    December 12th, 2009 @ 03:29 PM

  3. Jocelyn Legault
    Jocelyn Legault

    I just tried it on my machine and it looks just fine.
    A little thing I noticed however that we might want to address (or not): The gmock lib is called gmock.lib for all four configurations (VC8, VC9 in both Debug and Release). However, the gtest lib is called gtest.lib only in release. It's called gtestd.lib in Debug (both VC8 and VC9). I'm thinking since we have our own branch, we could harmonize the gmock and gtest library names. I don't really care which pattern we choose, but it'd be nice if it was uniform. OTOH, it's an issue that's of hte least importance... But since you're updating them, now could be a nice time to take care of that.

    Also, it seems I can't ack for this project! :-)

    February 7th, 2010 @ 05:34 AM

  4. Thell Fowler
    Thell Fowler

    That's odd. I'll look into the ack'ing authority issue.

    Re: naming. You're absolutely correct that they should follow the same naming convention. IMO, it would be easier to just use the name proper vs appending a 'd'. They are now side-by-side, so there is no ambiguity created by the name.

    February 12th, 2010 @ 09:30 PM

  5. Thell Fowler
    Thell Fowler
    • State changed from open to acked
    • Assigned user changed from Thell Fowler to npp-community

    It looks like you had authority to ack, we just hadn't setup the state tags for it. - Resolved

    Proposed and Candidate are not available for Gtest and Mock since we are not using the graduating branches one these projects like we are with npp-community. Acked topics here that have a matching npp-community topic will remain as acked until the npp-community topic makes it to master in the npp-community repo.

    February 19th, 2010 @ 11:57 PM

  6. Thell Fowler
    Thell Fowler
    • Milestone set to npp-community 2.0

    February 19th, 2010 @ 11:59 PM

  7. Thell Fowler
    Thell Fowler
    • Assigned user cleared.
    • State changed from acked to resolved

    February 26th, 2010 @ 03:47 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.