Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

[Feature] RoxyScroll

#23

Implement a scroll bar that displays an overview of the current file, including:

  • Current screen representation
  • Comments
  • Bookmarks
  • Smart highlighting
  • Line change markers

This feature is based on RockScroll for VisualStudio.

A screenshot of RockScroll in action

A screenshot of RockScroll in action

Reported by Jocelyn Legault · November 26th, 2009 @ 08:18 AM

State: open
Milestone: v2.0.0
Assigned to: Jocelyn Legault Jocelyn Legault

Activity

  1. Jocelyn Legault
  2. Jocelyn Legault
    Jocelyn Legault

    (from [d10ee34ceb68a6eb0e31a1736317a2a317090ab5]) RoxyScroll: Create the front-end UI

    • The front-end UI for RoxyScroll controls is created and the parameters for it are saved.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/d10ee34ceb68a6eb0e31a17...

    January 7th, 2010 @ 06:19 PM

  3. Jocelyn Legault
    Jocelyn Legault

    (from [81338e47f953cd28e5589785f98ef2bf59ad6b96]) Preference UI: fix blink rate scroller.

    • The blink rate scroller was not showing in it entirety and was clipped at the bottom. It's now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/81338e47f953cd28e558978...

    January 7th, 2010 @ 06:19 PM

  4. Jocelyn Legault
    Jocelyn Legault

    (from [0bbf0aa75d7ba71385f44557ffbf688ea91c59d6]) RoxyScroll: imported a bunch of code from CoolSB.

    • DO NOT SYNC TO THIS!!!!
    • Intermediate commit.
    • Code is a mess. This is really just in temporary dev condition.
    • Everything compiles and works as it did before.
    • However, new wanted behavior (arbitrary vertical SB width) does not.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/0bbf0aa75d7ba71385f4455...

    January 12th, 2010 @ 01:05 AM

  5. Jocelyn Legault
    Jocelyn Legault

    (from [714245b9f8d195e5341c9f5bb8301d16480faac7]) RoxyScroll: custom sized scrollbar

    • The scroll bar can be of whatever size you like.
    • The code is mostly code from CoolSB that has been added.
    • The size and position of the scrollbar thumb is broken.
    • Intermediate commit and ugly as a sin. Still needs lots or work and love.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/714245b9f8d195e5341c9f5...

    January 16th, 2010 @ 12:43 AM

  6. Jocelyn Legault
    Jocelyn Legault

    (from [7330359e6bd9a78e56a0bc8fff655400f2070613]) Scintilla views: reorder inits to avoid crashes.

    • The current scintilla window pointer was assigned before the views were actually init, leading to crashes in some circumstances when accessing the current view while it was being initialized.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/7330359e6bd9a78e56a0bc8...

    January 26th, 2010 @ 05:59 AM

  7. Jocelyn Legault
    Jocelyn Legault

    (from [34a5a4f7b4c5942ceae447c05ef198ad37cdd28f]) Custom drawn scrollbar: sync to most messages.

    • The proto-RoxyScroll bars are responding almost as a default Win32 scrollbar.
    • Only behavior that is still not linked is mouse dragged scroller.
    • Code is still terribly experimental and in no shape to be used as is in production.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/34a5a4f7b4c5942ceae447c...

    January 26th, 2010 @ 05:59 AM

  8. Jocelyn Legault
    Jocelyn Legault

    (from [865cfc3a9ebd40cc545196c75f7c774c8cc75dc1]) Hook mouse move scroll.

    • Moving the scroller with the mouse now behaves as expected.
    • Still just a bunch of experimental code.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/865cfc3a9ebd40cc545196c...

    January 27th, 2010 @ 04:04 AM

  9. Jocelyn Legault
    Jocelyn Legault

    (from [e30f45ad37be0ba3e6322cbd015e46b17b8c23ba]) RoxyScroll: better scrollbar behavior.

    • Behavior more consistent with RockScroll behavior:
      • The horizontal scrollbar only shows up if needed
      • The vertical scrollbar takes all the height of the window.
    • Removed the code that controlled the "dead area" since we won't need it anymore.
    • Code is still of prototype quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/e30f45ad37be0ba3e6322cb...

    January 30th, 2010 @ 03:40 AM

  10. Jocelyn Legault
    Jocelyn Legault

    (from [dac6da0e49290b4966775d00d041f93515975c99]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • There appears to be a crash on exit. This needs more investigation.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/dac6da0e49290b4966775d0...

    January 30th, 2010 @ 08:16 AM

  11. Jocelyn Legault
    Jocelyn Legault

    (from [3a511d4bc1ca27a4f9b28e1fd2e3c1590b2ad0ae]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • There appears to be a crash on exit. This needs more investigation.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/3a511d4bc1ca27a4f9b28e1...

    January 30th, 2010 @ 07:16 PM

  12. Jocelyn Legault
    Jocelyn Legault

    (from [fdcbfc0289d09916f469511504b04b67b4623dc1]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • There appears to be a crash on exit. This needs more investigation.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/fdcbfc0289d09916f469511...

    January 31st, 2010 @ 12:07 AM

  13. Jocelyn Legault
    Jocelyn Legault

    (from [dd38f767bdbb8ca1674c020b0198576766523bc6]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • There appears to be a crash on exit. This needs more investigation.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/dd38f767bdbb8ca1674c020...

    January 31st, 2010 @ 12:11 AM

  14. Jocelyn Legault
    Jocelyn Legault

    (from [7fdc0e9b2a1611bf683452cc4ad0e4d4cd343aa6]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/7fdc0e9b2a1611bf683452c...

    January 31st, 2010 @ 12:17 AM

  15. Jocelyn Legault
    Jocelyn Legault

    (from [1ae2edce85f7973d6c41ccc58eb9eae0bacb24c6]) RoxyScroll: Move the Roxy code in its own files.

    • Most of the code of RoxyScroll has been moved it int own files.
    • The only pieces of code that are left in ScintillaWin are for the non-client (WS_NC*) overrides and hooks to handle user drawn scrollbars.
    • Global variables were eliminated (they were either useless or were pertaining to wither RoxyScrollBar or RoxyScrollWnd. This allowed for proper handing of RoxyScroll on multiple windows inside the application.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/1ae2edce85f7973d6c41ccc...

    January 31st, 2010 @ 09:04 PM

  16. Jocelyn Legault
    Jocelyn Legault

    (from [02ab8db9d1a7f34b6303a6ef5868f00e3a0e33f3]) RoxyScroll: Fix the redraw issue for 0 length buttons

    • RoxyScroll now handles scrollbars with no arrow buttons properly.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/02ab8db9d1a7f34b6303a6e...

    February 1st, 2010 @ 12:02 AM

  17. Jocelyn Legault
    Jocelyn Legault

    (from [00920b4483261a6508e7fa59eeb9b1dc083c2068]) RoxyScroll: Assume we always custom draw.

    • We can safely assume that we will always be custom drawing and thus, we don't need to treat custom drawing as a special case and deffer it to some other entity. Therefore, all the code dealing with custom drawing has been removed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/00920b4483261a6508e7fa5...

    February 1st, 2010 @ 12:50 AM

  18. Jocelyn Legault
    Jocelyn Legault

    (from [87500d74a204490db84480cbf2c6088bd976dcd1]) RoxyScroll: Draw the thumb over the scrollbar.

    • Since the thumbnail of RoxyScroll will be in alpha-blended overlay on top of the scrollbar representing the file, the code now draw the scrollbar whole and draw the thumb and arrows on top instead of doing it piecemeal.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/87500d74a204490db84480c...

    February 1st, 2010 @ 12:50 AM

  19. Jocelyn Legault
    Jocelyn Legault

    (from [fd785b5259fece128dd7d332515eca445e95c879]) RoxyScroll: Draw the thumb over the scrollbar.

    • Since the thumbnail of RoxyScroll will be in alpha-blended overlay on top of the scrollbar representing the file, the code now draw the scrollbar whole and draw the thumb and arrows on top instead of doing it piecemeal.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/fd785b5259fece128dd7d33...

    February 1st, 2010 @ 07:23 AM

  20. Jocelyn Legault
    Jocelyn Legault
    • State changed from new to open

    February 4th, 2010 @ 12:36 AM

  21. Jocelyn Legault
    Jocelyn Legault

    (from [f9aba902b785dadcb9ff4c0cfafdb3201bcf7dab]) RoxyScroll: Fix scrollbar when no thumb is shown.

    • The scrollbar would not draw correctly when no thumb was shown. This was because we were using an uninitialized rectangle in those cases. The problem is now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/f9aba902b785dadcb9ff4c0...

    February 15th, 2010 @ 06:35 PM

  22. Jocelyn Legault
    Jocelyn Legault

    (from [300c89505eaabe8a84b6ea1f9756b7c7bde7b76e]) RoxyScroll: remove useless drawing code.

    • The thumb and the scrollbar were redrawn in places where it should not have been. This has now been fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/300c89505eaabe8a84b6ea1...

    February 15th, 2010 @ 06:35 PM

  23. Jocelyn Legault
    Jocelyn Legault

    (from [9cd3e0d25099cfd948a4fc4a13e1cc596ad75a88]) RoxyScroll: Move the paint functions in RoxyScrollBar.

    • The paint functions were moved to the RoxyScrollBar object in preparation for the drawing modifications that will make the drawing of the scrollbar double buffered.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/9cd3e0d25099cfd948a4fc4...

    February 15th, 2010 @ 06:35 PM

  24. Jocelyn Legault
    Jocelyn Legault

    (from [82daae057d0c2e27f81c97ba224ddf73de2312d0]) Preference UI: fix blink rate scroller.

    • The blink rate scroller was not showing in it entirety and was clipped at the bottom. It's now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/82daae057d0c2e27f81c97b...

    February 19th, 2010 @ 07:43 AM

  25. Jocelyn Legault
    Jocelyn Legault

    (from [a13983e0915b369ec5c8dc4bf057e6a61563385c]) RoxyScroll: imported a bunch of code from CoolSB.

    • DO NOT SYNC TO THIS!!!!
    • Intermediate commit.
    • Code is a mess. This is really just in temporary dev condition.
    • Everything compiles and works as it did before.
    • However, new wanted behavior (arbitrary vertical SB width) does not.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/a13983e0915b369ec5c8dc4...

    February 19th, 2010 @ 07:43 AM

  26. Jocelyn Legault
    Jocelyn Legault

    (from [430365e9769906e3e90c9ecd609c32b4b5fed34a]) Scintilla views: reorder inits to avoid crashes.

    • The current scintilla window pointer was assigned before the views were actually init, leading to crashes in some circumstances when accessing the current view while it was being initialized.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/430365e9769906e3e90c9ec...

    February 19th, 2010 @ 07:43 AM

  27. Jocelyn Legault
    Jocelyn Legault

    (from [06a73a48092790eeda954a3442c60412bcadbac0]) Hook mouse move scroll.

    • Moving the scroller with the mouse now behaves as expected.
    • Still just a bunch of experimental code.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/06a73a48092790eeda954a3...

    February 19th, 2010 @ 07:43 AM

  28. Jocelyn Legault
    Jocelyn Legault

    (from [58bd410ad7d871124d72085997f3693522cfeeca]) RoxyScroll: Move the Roxy code in its own files.

    • Most of the code of RoxyScroll has been moved it int own files.
    • The only pieces of code that are left in ScintillaWin are for the non-client (WS_NC*) overrides and hooks to handle user drawn scrollbars.
    • Global variables were eliminated (they were either useless or were pertaining to wither RoxyScrollBar or RoxyScrollWnd. This allowed for proper handing of RoxyScroll on multiple windows inside the application.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/58bd410ad7d871124d72085...

    February 19th, 2010 @ 07:43 AM

  29. Jocelyn Legault
    Jocelyn Legault

    (from [7d84dd07a4e176a9ee82ff14a9f9bbc44d3b5b8f]) RoxyScroll: Create the front-end UI

    • The front-end UI for RoxyScroll controls is created and the parameters for it are saved.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/7d84dd07a4e176a9ee82ff1...

    February 19th, 2010 @ 07:43 AM

  30. Jocelyn Legault
    Jocelyn Legault

    (from [30beaae40238b6851ddc619667c588d068f73a1d]) Custom drawn scrollbar: sync to most messages.

    • The proto-RoxyScroll bars are responding almost as a default Win32 scrollbar.
    • Only behavior that is still not linked is mouse dragged scroller.
    • Code is still terribly experimental and in no shape to be used as is in production.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/30beaae40238b6851ddc619...

    February 19th, 2010 @ 07:43 AM

  31. Jocelyn Legault
    Jocelyn Legault

    (from [fe8ce486f4295e8734c88755c04b5768cee3dc0c]) RoxyScroll: Assume we always custom draw.

    • We can safely assume that we will always be custom drawing and thus, we don't need to treat custom drawing as a special case and deffer it to some other entity. Therefore, all the code dealing with custom drawing has been removed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/fe8ce486f4295e8734c8875...

    February 19th, 2010 @ 07:43 AM

  32. Jocelyn Legault
    Jocelyn Legault

    (from [c7c3c18cdb084d670876d02c8d1e364fd8a6cf79]) RoxyScroll: Draw the thumb over the scrollbar.

    • Since the thumbnail of RoxyScroll will be in alpha-blended overlay on top of the scrollbar representing the file, the code now draw the scrollbar whole and draw the thumb and arrows on top instead of doing it piecemeal.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/c7c3c18cdb084d670876d02...

    February 19th, 2010 @ 07:43 AM

  33. Jocelyn Legault
    Jocelyn Legault

    (from [0219752a56e82c35fa746bf4733573d8d811a39a]) RoxyScroll: Fix scrollbar when no thumb is shown.

    • The scrollbar would not draw correctly when no thumb was shown. This was because we were using an uninitialized rectangle in those cases. The problem is now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/0219752a56e82c35fa746bf...

    February 19th, 2010 @ 07:43 AM

  34. Jocelyn Legault
    Jocelyn Legault

    (from [4f48ea18626b8bad8405d63e0e862dba27ed0844]) RoxyScroll: custom sized scrollbar

    • The scroll bar can be of whatever size you like.
    • The code is mostly code from CoolSB that has been added.
    • The size and position of the scrollbar thumb is broken.
    • Intermediate commit and ugly as a sin. Still needs lots or work and love.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/4f48ea18626b8bad8405d63...

    February 19th, 2010 @ 07:43 AM

  35. Jocelyn Legault
    Jocelyn Legault

    (from [0a51c99cb49ee89be5af87ced604ea1560c9237f]) RoxyScroll: remove useless drawing code.

    • The thumb and the scrollbar were redrawn in places where it should not have been. This has now been fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/0a51c99cb49ee89be5af87c...

    February 19th, 2010 @ 07:43 AM

  36. Jocelyn Legault
    Jocelyn Legault

    (from [498ce7fdbe37ccc0b7eeb0c62cd0a8a426b49488]) RoxyScroll: Move the paint functions in RoxyScrollBar.

    • The paint functions were moved to the RoxyScrollBar object in preparation for the drawing modifications that will make the drawing of the scrollbar double buffered.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/498ce7fdbe37ccc0b7eeb0c...

    February 19th, 2010 @ 07:43 AM

  37. Jocelyn Legault
    Jocelyn Legault

    (from [505a202a7cba3b22cd49edcb5aaa65751f128575]) RoxyScroll: better scrollbar behavior.

    • Behavior more consistent with RockScroll behavior:
      • The horizontal scrollbar only shows up if needed
      • The vertical scrollbar takes all the height of the window.
    • Removed the code that controlled the "dead area" since we won't need it anymore.
    • Code is still of prototype quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/505a202a7cba3b22cd49edc...

    February 19th, 2010 @ 07:43 AM

  38. Jocelyn Legault
    Jocelyn Legault

    (from [1b0287f675ed988f569c984513cac473c816d144]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/1b0287f675ed988f569c984...

    February 19th, 2010 @ 07:43 AM

  39. Jocelyn Legault
    Jocelyn Legault

    (from [55350c365012ba03e535d506b40f9542b2c859ed]) RoxyScroll: Fix the redraw issue for 0 length buttons

    • RoxyScroll now handles scrollbars with no arrow buttons properly.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/55350c365012ba03e535d50...

    February 19th, 2010 @ 07:43 AM

  40. Jocelyn Legault
  41. Jocelyn Legault
    Jocelyn Legault

    (from [8355d014f86eede70e4f979aef89dd40a045ebc4]) RoxyScroll classes: remove useless members.

    • Removed useless data members and methods from RoxyScrollBar and RoxyScrollWnd. These were leftovers from CoolSB.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/8355d014f86eede70e4f979...

    February 28th, 2010 @ 03:36 AM

  42. Jocelyn Legault
    Jocelyn Legault

    (from [6facfd88c91c7dfbdac1437bc5eefd1370986334]) RoxyScroll: move initialization items to RoxyScrollBar

    • A few items belonging to RoxyScrollBar were still instantiated in RoxyScrollWnd. This is now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/6facfd88c91c7dfbdac1437...

    February 28th, 2010 @ 03:36 AM

  43. Jocelyn Legault
    Jocelyn Legault

    (from [3446ec27481394d3e3204e220e8658e37d6a3862]) RoxyScroll: initialize double buffer

    • Creation and initialization of the double buffer.
    • Temporary implementation as a proof of concept. Should be evolving in future commits.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/3446ec27481394d3e3204e2...

    February 28th, 2010 @ 03:36 AM

  44. Jocelyn Legault
    Jocelyn Legault

    (from [0dc2ac3553db936362a612a3f64339fe1cdd8967]) RoxyScroll: Create the front-end UI

    • The front-end UI for RoxyScroll controls is created and the parameters for it are saved.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/0dc2ac3553db936362a612a...

    February 28th, 2010 @ 03:56 AM

  45. Jocelyn Legault
    Jocelyn Legault

    (from [ca7b8abe8252c37d64d91ef79a19a8d424359121]) RoxyScroll: imported a bunch of code from CoolSB.

    • DO NOT SYNC TO THIS!!!!
    • Intermediate commit.
    • Code is a mess. This is really just in temporary dev condition.
    • Everything compiles and works as it did before.
    • However, new wanted behavior (arbitrary vertical SB width) does not.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/ca7b8abe8252c37d64d91ef...

    February 28th, 2010 @ 03:56 AM

  46. Jocelyn Legault
    Jocelyn Legault

    (from [52224951c8f3aa33722ff0646f6e0ae54102efb0]) Preference UI: fix blink rate scroller.

    • The blink rate scroller was not showing in it entirety and was clipped at the bottom. It's now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/52224951c8f3aa33722ff06...

    February 28th, 2010 @ 03:56 AM

  47. Jocelyn Legault
    Jocelyn Legault

    (from [0b674650f3081daeff56fcaa71e22e7e80722001]) Scintilla views: reorder inits to avoid crashes.

    • The current scintilla window pointer was assigned before the views were actually init, leading to crashes in some circumstances when accessing the current view while it was being initialized.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/0b674650f3081daeff56fca...

    February 28th, 2010 @ 03:56 AM

  48. Jocelyn Legault
    Jocelyn Legault

    (from [28bc57d48ffc27128f18d2813a9d86d7f55c6611]) Hook mouse move scroll.

    • Moving the scroller with the mouse now behaves as expected.
    • Still just a bunch of experimental code.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/28bc57d48ffc27128f18d28...

    February 28th, 2010 @ 03:56 AM

  49. Jocelyn Legault
    Jocelyn Legault

    (from [1184a7501d3d4a65ee6fae665f8541b126bef223]) Custom drawn scrollbar: sync to most messages.

    • The proto-RoxyScroll bars are responding almost as a default Win32 scrollbar.
    • Only behavior that is still not linked is mouse dragged scroller.
    • Code is still terribly experimental and in no shape to be used as is in production.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/1184a7501d3d4a65ee6fae6...

    February 28th, 2010 @ 03:56 AM

  50. Jocelyn Legault
    Jocelyn Legault

    (from [93546b4f0986d6020acdf807cb19a7d3cf45c2e1]) RoxyScroll: better scrollbar behavior.

    • Behavior more consistent with RockScroll behavior:
      • The horizontal scrollbar only shows up if needed
      • The vertical scrollbar takes all the height of the window.
    • Removed the code that controlled the "dead area" since we won't need it anymore.
    • Code is still of prototype quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/93546b4f0986d6020acdf80...

    February 28th, 2010 @ 03:56 AM

  51. Jocelyn Legault
    Jocelyn Legault

    (from [06e520bdd1616b051ef8788b965dd16f8e9530f3]) RoxyScrollWnd and RoxyScrollBar: "objectify" the code.

    • Several methods belonged to ScintillaWin for no real good reason.
    • RoxyScrollWnd was created from the SCROLLWND struct and RoxyScrollBar from the SCROLLBAR struct. They were both assigned the obvious methods that were theirs.
    • RoxyScrollWnd and RoxyScrollBar are now ready to be migrated to their own source files.
    • Code is still in prototype stage, but slowly gearing towards production quality.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/06e520bdd1616b051ef8788...

    February 28th, 2010 @ 03:56 AM

  52. Jocelyn Legault
    Jocelyn Legault

    (from [d1e71d69d556b2395ef8d67824a17f184cc98976]) RoxyScroll: Move the Roxy code in its own files.

    • Most of the code of RoxyScroll has been moved it int own files.
    • The only pieces of code that are left in ScintillaWin are for the non-client (WS_NC*) overrides and hooks to handle user drawn scrollbars.
    • Global variables were eliminated (they were either useless or were pertaining to wither RoxyScrollBar or RoxyScrollWnd. This allowed for proper handing of RoxyScroll on multiple windows inside the application.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/d1e71d69d556b2395ef8d67...

    February 28th, 2010 @ 03:56 AM

  53. Jocelyn Legault
    Jocelyn Legault

    (from [a4eed0a5a60e8e06794439a0e97b83fdc4cce41d]) RoxyScroll: Fix the redraw issue for 0 length buttons

    • RoxyScroll now handles scrollbars with no arrow buttons properly.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/a4eed0a5a60e8e06794439a...

    February 28th, 2010 @ 03:56 AM

  54. Jocelyn Legault
    Jocelyn Legault

    (from [34610b723f636775b12fe787e7d3d884a8239461]) RoxyScroll: Fix scrollbar when no thumb is shown.

    • The scrollbar would not draw correctly when no thumb was shown. This was because we were using an uninitialized rectangle in those cases. The problem is now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/34610b723f636775b12fe78...

    February 28th, 2010 @ 03:56 AM

  55. Jocelyn Legault
    Jocelyn Legault

    (from [d257e4b9f6e1986cf8c209258616852748ad3839]) RoxyScroll: remove useless drawing code.

    • The thumb and the scrollbar were redrawn in places where it should not have been. This has now been fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/d257e4b9f6e1986cf8c2092...

    February 28th, 2010 @ 03:56 AM

  56. Jocelyn Legault
    Jocelyn Legault

    (from [72b109774d0b16bc3e8b4ed3430fcf6fbf4e84e3]) RoxyScroll: Assume we always custom draw.

    • We can safely assume that we will always be custom drawing and thus, we don't need to treat custom drawing as a special case and deffer it to some other entity. Therefore, all the code dealing with custom drawing has been removed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/72b109774d0b16bc3e8b4ed...

    February 28th, 2010 @ 03:56 AM

  57. Jocelyn Legault
    Jocelyn Legault

    (from [3e2e35703af1d95fb9c3681d0cf565be418a3aa2]) RoxyScroll: Move the paint functions in RoxyScrollBar.

    • The paint functions were moved to the RoxyScrollBar object in preparation for the drawing modifications that will make the drawing of the scrollbar double buffered.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/3e2e35703af1d95fb9c3681...

    February 28th, 2010 @ 03:56 AM

  58. Jocelyn Legault
    Jocelyn Legault

    (from [b70c7295536c0cea2929af5039335aea92ebbdd5]) RoxyScroll: Draw the thumb over the scrollbar.

    • Since the thumbnail of RoxyScroll will be in alpha-blended overlay on top of the scrollbar representing the file, the code now draw the scrollbar whole and draw the thumb and arrows on top instead of doing it piecemeal.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/b70c7295536c0cea2929af5...

    February 28th, 2010 @ 03:56 AM

  59. Jocelyn Legault
    Jocelyn Legault

    (from [fc65fb46a71c1ad85201b8b9b18000dd3c5dc675]) RoxyScroll classes: remove useless members.

    • Removed useless data members and methods from RoxyScrollBar and RoxyScrollWnd. These were leftovers from CoolSB.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/fc65fb46a71c1ad85201b8b...

    February 28th, 2010 @ 03:56 AM

  60. Jocelyn Legault
    Jocelyn Legault

    (from [74a01eda7ec0506ad04b8db9672ec5a9fc0dfa59]) RoxyScroll: custom sized scrollbar

    • The scroll bar can be of whatever size you like.
    • The code is mostly code from CoolSB that has been added.
    • The size and position of the scrollbar thumb is broken.
    • Intermediate commit and ugly as a sin. Still needs lots or work and love.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/74a01eda7ec0506ad04b8db...

    February 28th, 2010 @ 03:56 AM

  61. Jocelyn Legault
  62. Jocelyn Legault
    Jocelyn Legault

    (from [9edccb990aaa6adc74ce256b8c8bdd12f8970292]) RoxyScroll: initialize double buffer

    • Creation and initialization of the double buffer.
    • Temporary implementation as a proof of concept. Should be evolving in future commits.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/9edccb990aaa6adc74ce256...

    February 28th, 2010 @ 03:56 AM

  63. Jocelyn Legault
    Jocelyn Legault

    (from [5bf6ea764215d5e5e5808a7f89cb4c7c67c84ec8]) RoxyScroll: move initialization items to RoxyScrollBar

    • A few items belonging to RoxyScrollBar were still instantiated in RoxyScrollWnd. This is now fixed.

    [#23 [Feature] RoxyScroll]

    Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
    http://github.com/joce/npp-community/commit/5bf6ea764215d5e5e5808a7...

    February 28th, 2010 @ 03:56 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.