[Improvement] Remove all the additional include folders from the project.
Reported by Jocelyn Legault | November 25th, 2009 @ 11:49 PM
There is a boatload of additional include folders in the PowerEditor vcproj. All the sub folders of the project are added there. This is wrong for two reasons:
a) It creates a very real potential for name clashing with the
include files.
b) Having so many additional folders just creates more folders for
the build process to search and has a real potential to increases
build times.
For these reasons, it would be wise to remove most of the additional include directories from the vcprojs (both v8 and v9) and make the appropriate changes to the source files to reflect that change.
The header files include guards will also have to be modified to
reflect this change. You would not want /a/b/foo.h
being included to prevent the inclusion of /c/foo.h
later on in a source file.
The include guards will have to be of the
form:FOLDERA_FOLDERB_FILENAME_H
Comments and changes to this ticket
-
Jocelyn Legault November 25th, 2009 @ 11:53 PM
- Title changed from “[Imporvement] Remove all the additional include folders from the project.” to “[Improvement] Remove all the additional include folders from the project.”
-
Jocelyn Legault November 26th, 2009 @ 12:34 AM
That also allows you to ask fun questions like:
"Why is it thatWordStyleDlg.his inWinControls/ColourPicker"? -
Jocelyn Legault November 26th, 2009 @ 06:39 AM
- State changed from “open” to “needs_ack”
- Assigned user changed from “Jocelyn Legault” to “npp-community”
(from [0b492a3b7f89a808e4e65ae450d32ccfe3531869]) VCProj: Remove most of the additional include dirs.
- With the exception of
../srcand../../Scintilla/include, all the additional folders have been removed from the vcprojs (2005 and 2008). - Consequence of that, all the header files are expressed
relative to
../src(or../../Scintilla/include). - To help avoid name clashes, all the header guards have been
renamed in the form
FOLDERA_FOLDERB_FILE_H.
[#22 state:needs_ack responsible:npp-community]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/0b492a3b7f89a808e4e65ae... -
Jocelyn Legault November 26th, 2009 @ 08:03 AM
(from [641c06697b3603268a38c5d371714a73e2bb926d]) Header guards: remove useless #pragma once.
#pragma onceis useless in the scope of our project since we surround explicitly our#includes in header files with header guards.
[#22 state:needs_ack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/641c06697b3603268a38c5d... -
Jocelyn Legault November 26th, 2009 @ 08:03 AM
(from [74594d2d8c3140d9a2d9bf84cf95f6858762645f]) Project: remove useless files.
- Useless files were found and removed from the project.
[#22 state:needs_ack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/74594d2d8c3140d9a2d9bf8... -
Jocelyn Legault November 26th, 2009 @ 08:03 AM
(from [5144f846e81c69eb70d59b295d4ebf211a784696]) Project: correct major typo 'Scitilla' for 'Scintilla'.
- Fixed the folder name.
- Modified the includes.
- Modified the vcprojs
[#22 state:needs_ack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/5144f846e81c69eb70d59b2... -
Jocelyn Legault November 26th, 2009 @ 08:03 AM
(from [f8c2cc391743320106471b9545005389f9ad8463]) VCProjs: Update the projects to reflect dir structure
- Projects files have been modified to reflect the directory
structure more closely. The
Parametersgroup has been renamedCommonand now includescommon.h
[#22 state:needs_ack]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/f8c2cc391743320106471b9... - Projects files have been modified to reflect the directory
structure more closely. The
-
Thell Fowler November 28th, 2009 @ 09:49 PM
- State changed from “needs_ack” to “acked”
Personally I'd like to see this go even further. Taking a look at the PowerEditor/src/MISC directories I honestly don't see why the files aren't one level higher...
What does:
... |-- Debug | |-- npp_debug.cpp |-- npp_debug.h |-- Exception | |-- MiniDumper.cpp | |-- MiniDumper.h | |-- Win32Exception.cpp |-- Win32Exception.hadd to the source tree that
|-- npp_debug.cpp |-- npp_debug.h |-- MiniDumper.cpp |-- MiniDumper.h |-- Win32Exception.cpp |-- Win32Exception.h
doesn't?
Having said that though, this is acked and will be on pu shortly.
-
Thell Fowler November 29th, 2009 @ 06:35 AM
- State changed from “acked” to “proposed”
(from [ed204d730e76fcc67a020a05d4b7ff540c2762c5]) Merge branch 'jl/LH-22/nppcr-header-includes-cleanup' into pu
- jl/LH-22/nppcr-header-includes-cleanup: Project: correct major typo 'Scitilla' for 'Scintilla'. VCProjs: Update the projects to reflect dir structure Project: remove useless files. Header guards: remove useless #pragma once. VCProj: Remove most of the additional include dirs.
Conflicts:
PowerEditor/src/WinControls/DockingWnd/DockingCont.cpp PowerEditor/src/precompiled_headers.h[#22 state:proposed]
Acked-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/ed204d730e76fc... -
Thell Fowler December 7th, 2009 @ 06:14 AM
(from [8f900b51a00729e6f534af18a1d26392ed1508db]) Merge branch 'jl/LH-22/nppcr-header-includes-cleanup' into pu
- jl/LH-22/nppcr-header-includes-cleanup: Project: correct major typo 'Scitilla' for 'Scintilla'. VCProjs: Update the projects to reflect dir structure Project: remove useless files. Header guards: remove useless #pragma once. VCProj: Remove most of the additional include dirs.
Conflicts:
PowerEditor/src/WinControls/DockingWnd/DockingCont.cpp PowerEditor/src/precompiled_headers.h PowerEditor/visual.net/notepadPlus.8.vcproj[#22 state:proposed] http://github.com/npp-community/npp-community/commit/8f900b51a00729...
-
Thell Fowler December 7th, 2009 @ 09:47 PM
(from [6bca87657f161a86c4be113013777063600ab3e0]) Merge branch 'jl/LH-22/nppcr-header-includes-cleanup' into pu
- jl/LH-22/nppcr-header-includes-cleanup: Project: correct major typo 'Scitilla' for 'Scintilla'. VCProjs: Update the projects to reflect dir structure Project: remove useless files. Header guards: remove useless #pragma once. VCProj: Remove most of the additional include dirs.
Conflicts:
PowerEditor/src/WinControls/DockingWnd/DockingCont.cpp PowerEditor/src/precompiled_headers.h PowerEditor/visual.net/notepadPlus.8.vcproj[#22 state:proposed]
Acked-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/6bca87657f161a... -
Thell Fowler December 22nd, 2009 @ 03:53 PM
(from [0af9ab4e886fd4e817e5159f2ed706cfb518985f]) Merge branch 'jl/LH-22/nppcr-header-includes-cleanup' into pu
- jl/LH-22/nppcr-header-includes-cleanup: Project: correct major typo 'Scitilla' for 'Scintilla'. VCProjs: Update the projects to reflect dir structure Project: remove useless files. Header guards: remove useless #pragma once. VCProj: Remove most of the additional include dirs.
Conflicts:
PowerEditor/src/Notepad_plus.cpp PowerEditor/src/WinControls/DockingWnd/DockingCont.cpp PowerEditor/src/WinControls/WindowsDlg/WindowsDlg.cpp PowerEditor/src/precompiled_headers.h PowerEditor/visual.net/notepadPlus.8.vcproj[#22]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/0af9ab4e886f... -
Thell Fowler January 19th, 2010 @ 12:02 AM
(from [815b77cd5df30646a226d951ffbf759f7e718475]) Merge branch 'jl/LH-22/nppcr-header-includes-cleanup'
- jl/LH-22/nppcr-header-includes-cleanup: Project: correct major typo 'Scitilla' for 'Scintilla'. VCProjs: Update the projects to reflect dir structure Project: remove useless files. Header guards: remove useless #pragma once. VCProj: Remove most of the additional include dirs.
Conflicts:
PowerEditor/src/Notepad_plus.cpp PowerEditor/src/WinControls/DockingWnd/DockingCont.cpp PowerEditor/src/WinControls/WindowsDlg/WindowsDlg.cpp PowerEditor/src/precompiled_headers.h PowerEditor/visual.net/notepadPlus.8.vcproj[#22]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/815b77cd5df306... -
Thell Fowler January 19th, 2010 @ 12:07 AM
- State changed from “proposed” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Notepad++ Community Release
People watching this ticket
Jocelyn Legault
npp-community
Referenced by
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:needs_ack responsible:npp-community]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:needs_ack]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:needs_ack]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:needs_ack]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:needs_ack]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:proposed]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:proposed]
http://github.com/npp-community/npp...
-
22
[Improvement] Remove all the additional include folders from the project.
[#22
state:proposed]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22]
-
22
[Improvement] Remove all the additional include folders from the project.
[#22]