[Bug] Sticky hotspot style
Summary
In some circumstances, the hotspot highlight can be wrongly applied to documents.
Repro steps
- Open two documents, one of which has an http link on the top line.
- With your mouse hover on top of the link. Notice that the hotspot style is applied (see Hotspot_problem_step_1.png)
- Move you mouse up to the tab bar. Notice that the hotspot style is still applied; This is wrong
- Click on the tab of the other document. Notice that the hotspot style is wrongly applied to this document (see Hotspot_problem_step_2.png)
To fix this bug, we need to notify the document that the hotspot is no longer applied when the mouse exit the surface of the document.
Workaround
Simply move your mouse over the new document. The hotspot style will be removed.
Notes
- Pictures included.
- This is a low priority bug.
-
hotspot_problem_step_1.png
59.5 KB
-
hotspot_problem_step_2.png
65.7 KB
-
Jocelyn Legault- Milestone set to v2.0.0
-
Thell Fowler- State changed from new to open
- Assigned user set to Thell Fowler
Added patch to the Scintilla project tracker, and attached to this thread.
Will post branch to my repo this afternoon.
-
Thell Fowler
(from [2cc44b25efe2e425c266dd9d4ec4323e3347955e]) SciLexer: clear hotspot style when mouse leaves hotspot
- Hotspot styling was not being removed when mouse left either the ScintillaEditView client area or when it entered the margin area. This adds a call to SetHotSpotStyle(NULL) for both cases. Since SetHotSpotStyle does its' own checks before applying any change no additional checks have been added.
[#16]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/2cc44b25efe2... -
Thell Fowler
- State changed from open to needs_ack
- Assigned user changed from Thell Fowler to npp-community
-
Thell Fowler
(from [23223d7870fce0cfbe75907016ba9730a7d85d59]) SciLexer: clear hotspot style when mouse leaves hotspot
- Hotspot styling was not being removed when mouse left either the ScintillaEditView client area or when it entered the margin area. This adds a call to SetHotSpotStyle(NULL) for both cases. Since SetHotSpotStyle does its' own checks before applying any change no additional checks have been added.
[#16]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/23223d7870fc... -
Jocelyn Legault
- The commit comment no longer matches the code change.
On the current commit:
-
I don't have
commctrl32.dllon my machine. However, when I went looking for it online, I found that it's most probablycomctrl32.dllthat you are referring to (especially since it contained the function you want to get the address from). -
I'd personally put the whole dll loading block in its own method. Actually, when I went looking for it, I found
DynamicLibraryImplinwin32\PlatWin.cxx. This probably should be made use of. -
The parameter name in
ScintillaWin::SetTrackMouseLeaveEvent(bool on)is terrible. To 99.9% of humans, "on" means... well, on. It represents positive,1,truein people's mind. I'd use something more like "state" or something along those lines, or even better, an enum with even more sense:enum TrackState{ Tracked, Untracked };.
-
Thell Fowler
- State changed from needs_ack to acked
Discussion regarding this ticket took place on the scintilla-interest group in this thread and has been committed to Scintilla. Eventually we will be integrating that release, so I am all for accepting that into out Scintilla now.
I'll take Neil's commit as an ack, and put it up on pu. If there are any objections please speak up.
-
Thell Fowler
(from [73271487f3fb0a8a2efb25689bc0c0f6228f6802]) SciLexer: clear hotspot style when mouse leaves hotspot
- Hotspot styling was not being removed when mouse left either the ScintillaEditView client area or when it entered the margin area. This adds a call to SetHotSpotStyle(NULL) for both cases.
- This patch is the same as that being applied to Scintilla using Windows specific TrackMouseEvent.
[#16]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/73271487f3fb... -
Jocelyn Legault
All good with me.
-
Thell Fowler
- State changed from acked to proposed
-
Thell Fowler
(from [eeee799a0ea8e43c41851f28f8e3f7532a35e5cd]) Merge branch 'tf/LH-16v3/scilexer-fix-hotspot-style-clearing' into pu
- tf/LH-16v3/scilexer-fix-hotspot-style-clearing: SciLexer: clear hotspot style when mouse leaves hotspot
[#16]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/eeee799a0ea8e4... -
Thell Fowler
- State changed from proposed to resolved
This patch branch is being dropped as it was accepted into Scintilla, and Notepad++ has since updated its' Scintilla which includes the fix.
-
Thell Fowler
- Assigned user cleared.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.