Identify software components to Notepad++ CR
Reported by Jocelyn Legault | October 20th, 2009 @ 04:57 PM | in v1.0.0
- Make sure the "CR" appears in the software name in:
- Title bar
- Help > About
- File Properties
- In the file properties, the rest of the info (company, copyright, etc) should be updated as well.
- The file properties on SciLexer.dll should be updated as well to reflect that it's a custom N++CR build.
Comments and changes to this ticket
-
Jocelyn Legault October 20th, 2009 @ 05:01 PM
- Assigned user set to npp-community
-
Jocelyn Legault November 5th, 2009 @ 11:25 PM
- State changed from new to open
- Assigned user changed from npp-community to Jocelyn Legault
-
Jocelyn Legault November 5th, 2009 @ 11:26 PM
- Tag set to documentation, version
-
Jocelyn Legault December 3rd, 2009 @ 07:47 PM
- Assigned user changed from Jocelyn Legault to Thell Fowler
-
Thell Fowler December 3rd, 2009 @ 08:20 PM
- Assigned user changed from Thell Fowler to npp-community
- State changed from open to needs_ack
A patch series available at:
http://github.com/almostautomated/npp-community/tree/tf/LH-13/nppcr...
Should do what is needed to meet the requirements for a 1.0 tag. It consists of the following:
- 9feb4c6 branding: make about dialog and Help menu more CR specific
- 549510e resource.h: revert n++ version to keep upstream value
- f2a191a Notepad_plus.cpp: make window title show Notepad++ CR
- 7f332eb SciLexer.dll: relabel and automate fileversion info
-
Thell Fowler December 4th, 2009 @ 03:03 PM
Version 2 of this patch series is available after the review via IRC from Joce. It is available @:
http://github.com/almostautomated/npp-community/commits/tf/LH-13v2/...
- The about dialog was altered to a more 'standard' window style to allow dragging.
- Cleanup of the ircLink object and the now unused LICENSE_TEXT variable.
- Shortened the Scintilla version string from "Notepad++ Community Release" to "Notepad++ CR"
-
Thell Fowler December 6th, 2009 @ 05:13 PM
v3 available -- Amended to include ircLink AboutDlg default constructor.
http://github.com/almostautomated/npp-community/commit/056148a8cca0...
-
Jocelyn Legault December 6th, 2009 @ 07:19 PM
The style of the Close button in the ABout Dlg is sunken and IMO doesn't quite fit with the rest.
See the following screenshot: -
Thell Fowler December 6th, 2009 @ 07:50 PM
Button style updated.
Version 4 pushed and available at:
http://github.com/almostautomated/npp-community/tree/tf/LH-13v4/npp...
-
Jocelyn Legault December 6th, 2009 @ 10:56 PM
From an earlier IRC conversation, two new little adjustment were agreed upon:
<joce> Thell, would you hate me if I asked for 2 other small thingsÉ <joce> s/thingÉ/things?/ <Thell> _hate_ ... hrmmmm <Thell> maybe not <Thell> ;) <joce> be discontent? <joce> unhappy? <joce> pissed a bit? <joce> annoyed? <Thell> lol... not really... what are they? <joce> ANyways, I'll ask here, if you're okay with that, I'll update the ticket, if not, it's really no biggie <joce> 1- The help menu is named "?" instead of "Help" as 99.9% of the programs out there. * Thell nods <Thell> ##2? <joce> 2- the title of the about box is "About..." instead of "About" <joce> Or "About Notepad++ CR" <joce> both of them your call <joce> It's not really relateed to the ticket, but at the same time, it's right in the patch you've been playing in for a few days <Thell> The both sound reasonable</code>
-
Thell Fowler December 7th, 2009 @ 06:11 AM
- State changed from needs_ack to candidate
(from [36200995fb383ddfe9f3f0ae09214cbc78842a91]) Merge branch 'tf/LH-13v4/nppcr-relabel-components' into next
- tf/LH-13v4/nppcr-relabel-components: branding: make about dialog and Help menu CR specific resource.h: revert n++ version to keep upstream value Notepad_plus.cpp: make window title show Notepad++ CR SciLexer.dll: relabel and automate fileversion info
[#13 state:candidate]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/36200995fb383d... -
Thell Fowler December 7th, 2009 @ 09:28 PM
- Tag changed from documentation, version to amendment, documentation, version
(from [a002881d27758009fcae4875c4f2be28de4dea2b]) notepad_plus.rc: change menu name and window caption
- To match normal industry standard change '?' to 'Help' in the menu.
- Alter About dialog caption.
[#13 state:candidate tagged:amendment]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/a002881d277580... -
Thell Fowler December 7th, 2009 @ 09:28 PM
(from [fcc9f5ead02359909777fe391cfec2becbdb72ae]) notepad_plus.rc: increase field lengths in About dialog
- Date value gets truncated and the version value has a chance of getting truncated too so lengthen them to the length of the dialog.
[#13]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/fcc9f5ead02359... -
Thell Fowler December 7th, 2009 @ 09:28 PM
- State changed from candidate to resolved
(from [32b9c6fb01591bf1e6f9e3a28a9972a338065798]) Merge branch 'tf/LH-13v6/nppcr-relabel-components'
- tf/LH-13v6/nppcr-relabel-components: notepad_plus.rc: increase field lengths in About dialog notepad_plus.rc: change menu name and window caption branding: make about dialog and Help menu CR specific resource.h: revert n++ version to keep upstream value Notepad_plus.cpp: make window title show Notepad++ CR SciLexer.dll: relabel and automate fileversion info
[#13 state:resolved]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/32b9c6fb01591b...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Notepad++ Community Release
People watching this ticket
Referenced by
- 13 Identify software components to Notepad++ CR [#13 state:candidate]
- 13 Identify software components to Notepad++ CR [#13 state:candidate tagged:amendment]
- 13 Identify software components to Notepad++ CR [#13]
- 13 Identify software components to Notepad++ CR [#13 state:resolved]