Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Make project building a no-brainer.

#5

Issue

Using a pure environment variable for Google Test and Mock creates the situation that every developer must go through setting up environment variables, and some (like myself) may not wish to,

Proposal

Have the solution and project files use a two prop sheets for the finding of the additional directories. The environment prop sheet would take precedent over the default submodule locations, and a developer could even remove the default submodule location prop sheet if they so desired.

The projects then would automaticallt inheret the values and would not need to be altered by every dev.

Additional Benefit

In the future, when other libraries are extracted from the project and made into their own libraries (like TinyXml) the project could easily be updated in the prop sheets to include the new lib.

A branch has already been submitted and placed in pu to do this.

Reported by Thell Fowler · October 8th, 2009 @ 04:54 PM

State: resolved
Milestone: v1.0.0-rc1
Assigned to: Thell Fowler Thell Fowler

Activity

  1. Thell Fowler
    Thell Fowler
    • State changed from new to needs_ack

    (from [1bc509759ebd086712dc994deb8c5e7c47a2ceb5]) project files: update VC8 project files

    • add new lib path vsprops
    • rename $project.vc.8.0.vcproj files to $project.8.vcproj
    • remove the 'Unicode' portion of the build configuration's names since we that is all we build and it allows the usage of $(ConfigurationName) macros in the project settings to match up with Google Test and Mock project paths.

    [#5 Make project building a no-brainer. state:needs_ack]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/1bc509759ebd...

    October 8th, 2009 @ 05:44 PM

  2. npp-community
    npp-community
    • State changed from needs_ack to new

    Disregard, the above. We are still getting a workflow setup going. The changesets introduced by that previously referenced ticket update have been removed after learning about GitHub and the usage of Lighthouse service integration.

    The service hook does not work with a new branch!

    The branch needs to be created and pushed first, then hack away at the topic, and push again when it is ready.

    October 8th, 2009 @ 06:43 PM

  3. Thell Fowler
    Thell Fowler
    • State changed from new to needs_ack

    (from [0f5ba8bccb04891e28ab42510583c1615d5aa713]) Merge branch 'tf/nppcr-project-files-overhaul' into LH-5/tf/nppcr-project-files-overhaul

    • tf/nppcr-project-files-overhaul: project files: update VC8 project files project files: update VC9 project files vsprops: make environment and default path values valid vsprops: Dependency on Google [Mock|Test] is now dependant on an env var. vc8 solution: make release config use release build

    [#5 Make project building a no-brainer. state:needs_ack]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/0f5ba8bccb04...

    October 8th, 2009 @ 08:24 PM

  4. Jocelyn Legault
    Jocelyn Legault
    • State changed from needs_ack to open

    It was found to be compiling nicely on my machine, where the env vars are set and the Google Mock and Test sub projects are not.

    Only remaining (and AFAIK known) problem is:

    2>Project : warning PRJ0018 : The following environment variables were not found:
2>$(GTEST_DIR)

    Once this is fixed, we will be able to close the ticket.

    October 12th, 2009 @ 07:19 PM

  5. Thell Fowler
    Thell Fowler
    • State changed from open to cooking

    (from [8c403a63662329f441fe67a28c22777d00613169]) project files: remove remaining GTEST_DIR macro

    • The VC 9.0 Debug had a GTEST_DIR artifact still lingering in the config which caused a build warning.

    [#5 Make project building a no-brainer. state:cooking tag:branch-next]

    Acked by: Jocelyn Legault
    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/8c403a63662329...

    October 14th, 2009 @ 06:35 PM

  6. Thell Fowler
    Thell Fowler
    • Tag changed from project_files, solution, submodules, vc8, vc9 to branch-next, project_files, solution, submodules, vc8, vc9

    October 14th, 2009 @ 06:43 PM

  7. npp-community
    npp-community
    • State changed from cooking to candidate

    October 14th, 2009 @ 07:53 PM

  8. Thell Fowler
    Thell Fowler
    • State changed from candidate to resolved

    (from [336ddecd96f72d5890618ec1e78489a618170944]) Merge branch 'tf/nppcr-project-files-overhaul'

    • This merge commit was amended to also update the submodule tags: google_test to tag v1.3.0.3 google_mock to tag v1.1.0.3

    • tf/nppcr-project-files-overhaul: .gitmodules: use google test/mock 'next' branch project files: remove remaining GTEST_DIR macro project files: update VC8 project files project files: update VC9 project files vsprops: make environment and default path values valid vsprops: Dependency on Google [Mock|Test] is now dependant on an env var. vc8 solution: make release config use release build

    [#5 Make project building a no-brainer. state:resolved]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/336ddecd96f72d...

    October 17th, 2009 @ 05:01 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.