Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Introduce FuncGuard category setup

#32

#8 introduced FuncGuards, yet there is quite a bit of repo management involved for both the dev and the repo maintainer in ensuring that function guards don't make it into submitted patches.

In the thread for #8 Joce had brought up some very valid points regarding this issue:

The func_guard() statement needs to be there, but why would you expect the enable/disable statement to be in committed files? A single define in the npp_debug.h to check if there are active func_guards being read in from a non-tracked header seems to be a solution that eliminates having people stepping on each-others toes with enable statements.

That could be useful in some cases, but in many other, having a centralized category file will be rather cumbersome, and will cause full recompilations when adding / removing categories.

Also, for generic calls that can be done in more than one context, it makes much more sense IMO to have the enabling done at file level. Otherwise, you'd still have to have a context for that one file, but it would be declared in a foreign place. i.e. TinyXML. It is its own context. I don't see why the enabling of TinyXML guards should be done elsewhere than that, and disrupting the compilation of other files that have nothing to do with it.

Secondly, that would mean that we have a file that knows about all the project, from the top, but that could be included by the bottom. Allow me to explain: Even though we currently don't have any formal code hierarchy, we can agree that utility files like common.cpp are at the bottom of the pile and should not know anything about files implementing higher level concept, as the Docking*.cpp files for example. With the centralized concept you propose, common.cpp you be exposed, however indirectly, to docking concepts (the Docking category) that mean nothing to it.

So, while I'm not totally opposed to categories that have scopes broader that files, I think that should be layered, and we should be careful what we put and include where.

After discussing this on the irc channel it was agreed there should be a solution.

Here is what I am proposing:
* That there be three files added to support having FuncGuard categories enabled without the penalty of rebuilding the whole project when the state of one is altered. Those three files are:

  • FuncGuards_skel.h will define all of the project's function guards in a disabled state. An example of this file is available in the FuncGuards_skel.h.orig file posted to Github.

  • FuncGuards.cpp will set each FuncGuard to either the enabled or disabled state. It will include the precompiled header of the project and the active FuncGuards.h file. A sample of this file (minus the project specific includes) is available in the FuncGuards.cpp.orig on Github.

  • FuncGuardsImport.h has an import statement for each FuncGuard defined for the project and is included in the precompiled header. The sample for it is available at FuncGuardsImport.h.orig on Github.

Also added to the project would be a pre-build event that validates the existence of a FuncGuards.h file ignored by gitignore. This file would be created if it does not already exist by copying the FuncGuards_skel.h.

I believe that this setup balances the flexibility needs of a developer with the ability to share patches with others without fuss. Simply put, this setup allows a developer to git co -b MyTopic and alter whatever FuncGuards are enabled or disabled without even thinking about how that would effect their commits. Whenever the developer wanted to add a FuncGuard category they would simply add it to those files and commit/submit the addition.

As time goes on there would be more and more predefined FuncGuard categories for the classes, files, and function purposes available to every developer. When a new developer wants to learn how a particular area of the code works they'd simply enable a category and go. No more trying to find which functions relate to each other and how.

Reported by Thell Fowler · January 27th, 2010 @ 08:47 PM

State: resolved
Milestone: v2.0.0
Assigned to: nobody

Activity

  1. Thell Fowler
    Thell Fowler
    • State changed from new to open
    • Assigned user set to Thell Fowler
    • Milestone set to v2.0.0

    January 27th, 2010 @ 08:49 PM

  2. Thell Fowler
    Thell Fowler

    (from [e9d7edd2d5e25ee59d5b69e4e13874e1e9cc3169]) funcguards: introduce funcguard category setup

    • Add FuncGuards files to the VC 8 and 9 project files for the release and debug builds. Omitting the FuncGuards.cpp from the Shipping build.
    • Add pre-build event to copy FuncGuards_skel.h to FuncGuards.h when it doesn't exist.
    • Add FuncGuards.h and MISC/Debug/templates/ to .gitignore
    • Include the FunGuardsImporter header in the precompiled_headers.

    [#32] http://github.com/almostautomated/npp-community/commit/e9d7edd2d5e2...

    January 28th, 2010 @ 05:30 AM

  3. Thell Fowler
    Thell Fowler

    (from [d980f2e10a08eeb0070e19adf389351a3c2e2d31]) powereditor: introduce funcguard category setup

    • Add FuncGuards files to the VC 8 and 9 project files for the release and debug builds. Omitting the FuncGuards.cpp from the Shipping build.
    • Add pre-build event to copy FuncGuards_skel.h to FuncGuards.h when it doesn't exist.
    • Add FuncGuards.h,*.tmp, and MISC/Debug/templates/ to .gitignore
    • Include the FunGuardsImporter header in the precompiled_headers.

    [#32] http://github.com/almostautomated/npp-community/commit/d980f2e10a08...

    January 29th, 2010 @ 08:36 PM

  4. Thell Fowler
    Thell Fowler

    (from [c215870217a96f2f98f310288f39973fd715ed72]) common: make npp_debug common and add to Scintilla

    • Make the features of npp_debug available to Scintilla as they are to PowerEditor without creating extra files to maintain. This does create a higher level common link between the projects that has not existed before, the alternative (at this stage) is to have the npp_debug and CommonGenerics code duplicated.

    [#32] http://github.com/almostautomated/npp-community/commit/c215870217a9...

    January 31st, 2010 @ 04:42 PM

  5. Thell Fowler
    Thell Fowler

    (from [bc7e7f32544894b85c671b21297d99995c992c8b]) scintilla: add funcguard category setup

    • Update scintilla project to use the common npp_debug with function guard categories.

    [#32] http://github.com/almostautomated/npp-community/commit/bc7e7f325448...

    January 31st, 2010 @ 04:42 PM

  6. Thell Fowler
    Thell Fowler

    (from [291a53587ffae2c25f24e5199255ad9b4717d719]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/291a53587ffa...

    January 31st, 2010 @ 09:27 PM

  7. Joel "Jaykul" Bennett
    Joel "Jaykul" Bennett

    PowerShell Code acked by Joel Bennett :)

    January 31st, 2010 @ 09:37 PM

  8. Thell Fowler
    Thell Fowler
    • State changed from open to needs_ack
    • Assigned user changed from Thell Fowler to npp-community

    The C++ portions of this branch and the project setting changes still need to be acked by someone.

    Thanks

    January 31st, 2010 @ 09:46 PM

  9. Thell Fowler
    Thell Fowler

    (from [286121edc6f518f34f3876de1f8fa481e127ef64]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/286121edc6f5...

    February 12th, 2010 @ 06:07 AM

  10. Jocelyn Legault
    Jocelyn Legault

    SCRIPTS

    The current incarnation of the script throws an exception on my box when I Add-FuncGuard, as can be seen here:
    Add-FuncGuard exception

    I'll postpone the rest of the review of the scripts until this problem is fixed.

    README FILE

    In the README, before the first step of the installation, I'd mention the possibility to run the code from where it currently is. Something in the lines of

    If you want to run the script from it's current location, in PS do:
    > cd <n++cr-root>\contrib\FuncGuard-PowerShell-Module
    > $Env:PSModulePath
    Check that the current path is not listed
    > $Env:PSModulePath = $Env:PSModulePath + ";$(Get-Location)"
    > $Env:PSModulePath
    Check that the current path is listed
    > Get-Module -list
    Check that FuncGuard is listed.

    If you prefer running the script from a standard script location, do
    {here comes the current first step}


    In the README, before Module loading, I'd add

    Set execution permission if needed (see http://psobject.codeplex.com/wikipage?title=Execution%20Policy for more info)
    $Set-ExecutionPolicy RemoteSigned


    In the README, before Module loading, I'd add an how-to for the basic functionality: Add / Enable / Disable, as well as a short description of all the commands. I know that it's currently all in the command line help, but it's really a drag to have to go on the command line to get all the info. AN overview in the README would be more than welcome.

    February 16th, 2010 @ 04:27 AM

  11. Thell Fowler
    Thell Fowler

    (from [549823296f1c8a044d33d052bc9b8cd978736fda]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/549823296f1c...

    February 16th, 2010 @ 04:02 PM

  12. Thell Fowler
    Thell Fowler

    (from [eb86f1b37a837904f8746b9f589f503d78b4541d]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/eb86f1b37a83...

    February 19th, 2010 @ 12:16 AM

  13. Thell Fowler
    Thell Fowler

    (from [5d7af1b600559f25ccbf067333dc977b5f3206c2]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/5d7af1b60055...

    February 19th, 2010 @ 05:53 PM

  14. Thell Fowler
    Thell Fowler

    The above commit works for WinXP, WinVista, Win7, for users who have just installed PowerShellv2 and have not completed any PowerShell environment setup, including Set-ExecutionPolicy. It works for paths with spaces and without.

    February 19th, 2010 @ 06:30 PM

  15. Thell Fowler
    Thell Fowler

    Removing the FuncGuard-PowerShell-Module contrib from this patch series so the project's FuncGuard Setup can stand on its' own and the contrib can be it's own patch based upon this branch and be acked independently.

    The new contrib ticket will be #40

    February 20th, 2010 @ 05:19 PM

  16. Thell Fowler
    Thell Fowler

    (from [c5eb59411242f56cf2fbaf8f09a6c238ac9705df]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/c5eb59411242...

    February 20th, 2010 @ 05:32 PM

  17. Thell Fowler
    Thell Fowler

    (from [85968c7cac913721fe9338600f472bdbce91656b]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/85968c7cac91...

    February 20th, 2010 @ 06:47 PM

  18. Thell Fowler
    Thell Fowler

    (from [b34ac52245667499bd8403b5e5409552dfe52636]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/b34ac5224566...

    February 21st, 2010 @ 12:03 AM

  19. Thell Fowler
    Thell Fowler

    (from [d3542f1c4db305f10c2c4152bbfb298519ab85de]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/d3542f1c4db3...

    February 21st, 2010 @ 12:09 AM

  20. Thell Fowler
    Thell Fowler

    (from [feef014ac575ff302868fa90e6cdcda07c4eff48]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/feef014ac575...

    February 21st, 2010 @ 08:31 PM

  21. Jocelyn Legault
    Jocelyn Legault
    • State changed from needs_ack to acked

    The ticket seems to have followed both branches #40 and #32.
    For #32, I still need to be fully convinced, but it looks like it works as you intended.

    February 23rd, 2010 @ 03:17 AM

  22. Thell Fowler
    Thell Fowler

    (from [fb2037085721bac28eeb48053995f2ed2a080513]) powereditor: introduce funcguard category setup

    • Add FuncGuards files to the VC 8 and 9 project files for the release and debug builds. Omitting the FuncGuards.cpp from the Shipping build.
    • Add pre-build event to copy FuncGuards_skel.h to FuncGuards.h when it doesn't exist.
    • Add FuncGuards.h,*.tmp, and MISC/Debug/templates/ to .gitignore
    • Include the FunGuardsImporter header in the precompiled_headers.

    [#32] http://github.com/almostautomated/npp-community/commit/fb2037085721...

    February 27th, 2010 @ 03:48 PM

  23. Thell Fowler
    Thell Fowler

    (from [821f3195f3447513d3443bf618b0293daeeff654]) common: make npp_debug common and add to Scintilla

    • Make the features of npp_debug available to Scintilla as they are to PowerEditor without creating extra files to maintain. This does create a higher level common link between the projects that has not existed before, the alternative (at this stage) is to have the npp_debug and CommonGenerics code duplicated.

    [#32] http://github.com/almostautomated/npp-community/commit/821f3195f344...

    February 27th, 2010 @ 03:48 PM

  24. Thell Fowler
    Thell Fowler

    (from [758eb0f23375c6b1e6923dff663c9b5d297e3cea]) scintilla: add funcguard category setup

    • Update scintilla project to use the common npp_debug with function guard categories.

    [#32] http://github.com/almostautomated/npp-community/commit/758eb0f23375...

    February 27th, 2010 @ 03:48 PM

  25. Thell Fowler
    Thell Fowler

    Rebased onto topic [#42] to split out the addition of the Shipping configuration to Scintilla which now is a distinct patch.

    February 27th, 2010 @ 03:54 PM

  26. Thell Fowler
    Thell Fowler

    (from [a8f0650cece6f2e7a23b360baee1461e908ff3d1]) Merge branch 'tf/LH-32v8/introduce-funcguard-category-setup' into pu

    • tf/LH-32v8/introduce-funcguard-category-setup: funcguard: add Scintilla DllMain guard funcguard: add PowerEditor WinMain.cpp guards scintilla: add funcguard category setup common: make npp_debug common and add to Scintilla powereditor: introduce funcguard category setup

    • 32v8 differs from v7 in that it was rebased onto 59a5f36

    Conflicts:

    scintilla/src/precompiled_headers.h

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/a8f0650cece6f2...

    February 27th, 2010 @ 04:31 PM

  27. Thell Fowler
    Thell Fowler

    (from [5b2f8783156d7ba817c8a1951ac65886dd2b620a]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/almostautomated/npp-community/commit/5b2f8783156d...

    February 27th, 2010 @ 05:29 PM

  28. Thell Fowler
    Thell Fowler
    • State changed from acked to proposed

    February 27th, 2010 @ 05:34 PM

  29. Thell Fowler
    Thell Fowler

    (from [11859ce3232cc078fe0585c9751cbbfda3b1a914]) scintilla: add funcguard category setup

    • Update scintilla project to use the common npp_debug with function guard categories.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/11859ce3232cc0...

    October 31st, 2010 @ 06:56 PM

  30. Thell Fowler
    Thell Fowler

    (from [36f8d104d1749688a20f618cb672b52a1445bde7]) funcguard: add Scintilla DllMain guard

    • Add trace to the main entry point and resource load/release for SciLexer.dll. This patch does not enable the funcguard output, it only adds the guards to the source.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/36f8d104d17496...

    October 31st, 2010 @ 06:56 PM

  31. Thell Fowler
    Thell Fowler

    (from [2c746d89d87994fdcb6e71d5ed9e4504c941cf33]) powereditor: introduce funcguard category setup

    • Add FuncGuards files to the VC 8 and 9 project files for the release and debug builds. Omitting the FuncGuards.cpp from the Shipping build.
    • Add pre-build event to copy FuncGuards_skel.h to FuncGuards.h when it doesn't exist.
    • Add FuncGuards.h,*.tmp, and MISC/Debug/templates/ to .gitignore
    • Include the FunGuardsImporter header in the precompiled_headers.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/2c746d89d87994...

    October 31st, 2010 @ 06:56 PM

  32. Thell Fowler
    Thell Fowler

    (from [e4d4c62f045146f6feefc1c2b2354e485f76f34b]) Merge branch 'tf/LH-32v8/introduce-funcguard-category-setup'

    • tf/LH-32v8/introduce-funcguard-category-setup: funcguard: add Scintilla DllMain guard funcguard: add PowerEditor WinMain.cpp guards scintilla: add funcguard category setup common: make npp_debug common and add to Scintilla powereditor: introduce funcguard category setup

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/e4d4c62f045146...

    October 31st, 2010 @ 06:56 PM

  33. Thell Fowler
    Thell Fowler

    (from [179f4c02eaca99db8a447e8f989f1e922441ac81]) common: make npp_debug common and add to Scintilla

    • Make the features of npp_debug available to Scintilla as they are to PowerEditor without creating extra files to maintain. This does create a higher level common link between the projects that has not existed before, the alternative (at this stage) is to have the npp_debug and CommonGenerics code duplicated.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/179f4c02eaca99...

    October 31st, 2010 @ 06:56 PM

  34. Thell Fowler
    Thell Fowler

    (from [d6640396254c32b28025a1f32ebf9972907b22fb]) funcguard: add PowerEditor WinMain.cpp guards

    • Add trace for the main entry point and related functions in WinMain.cpp. This patch does not enable the funcguard output, it just adds the guards to the source.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/d6640396254c32...

    October 31st, 2010 @ 06:56 PM

  35. Thell Fowler
    Thell Fowler
    • State changed from proposed to resolved
    • Assigned user cleared.

    Rebased and merged to master.

    October 31st, 2010 @ 07:05 PM

  36. Thell Fowler
    Thell Fowler

    (from [37f0df9e63dbc17988844645180f6d5d749e84c9]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/37f0df9e63dbc1...

    October 31st, 2010 @ 07:20 PM

  37. Thell Fowler
    Thell Fowler

    (from [497c742db621bdb1b0bb8a8aec2a7604a2c37b62]) scintilla: add funcguard category setup

    • Update scintilla project to use the common npp_debug with function guard categories.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/497c742db621bd...

    October 31st, 2010 @ 09:28 PM

  38. Thell Fowler
    Thell Fowler

    (from [d338d973b84ad5cacf538a32b052dd20e2675fd7]) powereditor: introduce funcguard category setup

    • Add FuncGuards files to the VC 8 and 9 project files for the release and debug builds. Omitting the FuncGuards.cpp from the Shipping build.
    • Add pre-build event to copy FuncGuards_skel.h to FuncGuards.h when it doesn't exist.
    • Add FuncGuards.h,*.tmp, and MISC/Debug/templates/ to .gitignore
    • Include the FunGuardsImporter header in the precompiled_headers.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/d338d973b84ad5...

    October 31st, 2010 @ 09:28 PM

  39. Thell Fowler
    Thell Fowler

    (from [ac37ccf397bac932a1a9211f5bad4732398a05f4]) funcguard: add PowerEditor WinMain.cpp guards

    • Add trace for the main entry point and related functions in WinMain.cpp. This patch does not enable the funcguard output, it just adds the guards to the source.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/ac37ccf397bac9...

    October 31st, 2010 @ 09:28 PM

  40. Thell Fowler
    Thell Fowler

    (from [7f6074746c90dfa4ae44924d7998a3be8a0689f7]) [contrib]: introduce PowerShell FuncGuard module

    • Contribution of a FuncGuard tool for helping with the additions, removals, and syncronization of FuncGuard categories.

    • Includes Windows Explorer N++CR FuncGuards shortcut to setup the PowerShell FuncGuards environment as well as a FuncGuards-Setup script that can be executed from a PowerShell prompt for environment setup. These are provided for users who do not wish to make more permanent changes to their PowerShell environment using their profile.

    • Provides commands to be used from a PowerShell command line that automatically updates the PowerEditor or Scintilla header and source files used for FuncGuards.

      New-FuncGuardProject, Add-FuncGuardProject, Set-FuncGuardProject, Get-FuncGuardProject, Remove-FuncGuardProject, Add-FuncGuard, Get-FuncGuard, Enable-FuncGuard, Disable-FuncGuard, Remove-FuncGuard, Update-FuncGuardFiles

    • This patch sits on top of the introduce-funcguard-category-setup topic from LH [#32]

    [#40]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/7f6074746c90df...

    October 31st, 2010 @ 09:28 PM

  41. Thell Fowler
    Thell Fowler

    (from [02899d1096805a20e71c65d88b925bf705ba19e3]) common: make npp_debug common and add to Scintilla

    • Make the features of npp_debug available to Scintilla as they are to PowerEditor without creating extra files to maintain. This does create a higher level common link between the projects that has not existed before, the alternative (at this stage) is to have the npp_debug and CommonGenerics code duplicated.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/02899d1096805a...

    October 31st, 2010 @ 09:28 PM

  42. Thell Fowler
    Thell Fowler

    (from [a0adb8525cc5b707513fdbecf0a9a81fafba7427]) funcguard: add Scintilla DllMain guard

    • Add trace to the main entry point and resource load/release for SciLexer.dll. This patch does not enable the funcguard output, it only adds the guards to the source.

    [#32]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/a0adb8525cc5b7...

    October 31st, 2010 @ 09:28 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.