[FIX] GIT-VS-VERSION-GEN Spaced CACHE Path fix
Reported by Thell Fowler | February 20th, 2010 @ 04:16 PM | in v2.0.0
Cache file was not getting properly set when path had spaces in it, causing each build to re-generate the header which caused visual studio to project to be out of date.
Comments and changes to this ticket
-
Thell Fowler February 20th, 2010 @ 04:46 PM
The fix for this is to use the short path/filename so there aren't any spaces. There is a bug with the shortening method on pre WinXP SP2 systems that possibly could cause issues, Personally I don't like the idea of trying to cater to making things work on that old of systems for our developers since we don't even have a sln that'll load and build with head-aches on those systems either.
Thell
-
Thell Fowler February 20th, 2010 @ 04:47 PM
(from [7812f566d5f6ed4a3cf04252d24251ee8cda4109]) GIT-VS-VERSION-GEN: fix spaced cache out path handling
- Argument %1 was being checked using [%1], %~p1, and %~f1, as well as the cache file check method using a "%CACHE_FILE%" check in a for loop.a The new way uses "%1", %~s1, and %~fs1, as well as the cache file check being done using an unquoted %CACHE_FILE%. The ~s converts long file names to short. There is a known bug with the ~s option and pre WinXP SP2 systems where ~s doesn't expend properly.
[#39]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/7812f566d5f6... -
Thell Fowler February 20th, 2010 @ 04:47 PM
- State changed from “open” to “needs_ack”
-
Thell Fowler February 20th, 2010 @ 05:44 PM
- Assigned user changed from “Thell Fowler” to “npp-community”
-
Jocelyn Legault February 23rd, 2010 @ 05:20 AM
- State changed from “needs_ack” to “acked”
-
Thell Fowler February 26th, 2010 @ 05:07 PM
- Assigned user cleared.
- State changed from “acked” to “resolved”
Trivial fix - Promoted to master
Changeset [9caf507420c9d26889cb40f44a35b8cae0f77f32] by Thell Fowler
February 26th, 2010 @ 03:26 PM
Merge branch 'tf/LH-39/git-vs-version-gen-fix-cache-path'
- tf/LH-39/git-vs-version-gen-fix-cache-path: GIT-VS-VERSION-GEN: fix spaced cache out path handling http://github.com/npp-community/npp-community/commit/9caf507420c9d2
Committed by Thell Fowler
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Notepad++ Community Release
Jocelyn Legault
npp-community
