Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

[trivial] include ommitted SHIPPING definition in vc8 sln

#24

Add pre-processor definition to vc8 solution shipping configuration.

Reported by Thell Fowler · November 28th, 2009 @ 04:26 PM

State: resolved
Milestone: v1.0.0
Assigned to: npp-community npp-community

Activity

  1. Thell Fowler
    Thell Fowler
    • Assigned user changed from Thell Fowler to npp-community
    • State changed from new to needs_ack

    Since this is trivial I don't see anything wrong with getting it on master in tie for the next tag...

    Available for review at::
    http://github.com/almostautomated/npp-community/commits/tf/LH-24/ad...


    vc8 solution: include shipping preprocessor define

    • Add SHIPPING define to Shipping configuration in the vc8 solution to stop the inclusion of gtest.h

    [#24 state:needs_ack assigned:npp-community

    Signed-off-by: Thell Fowler git@tbfowler.name

    November 28th, 2009 @ 05:38 PM

  2. Jocelyn Legault
    Jocelyn Legault
    • State changed from needs_ack to acked

    Looked at the change and compiled on my machine. Everything looks A-OK.

    December 1st, 2009 @ 02:54 AM

  3. Thell Fowler
    Thell Fowler
    • State changed from acked to candidate

    (from [29fdbd2282100276f719a50321542e9ed6904f6b]) Merge branch 'tf/LH-24/add-VC8-shipping-define' into next

    • tf/LH-24/add-VC8-shipping-define: vc8 solution: include shipping preprocessor define

    [#24 state:candidate]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/29fdbd22821002...

    December 7th, 2009 @ 06:11 AM

  4. Thell Fowler
    Thell Fowler
    • State changed from candidate to resolved

    (from [39947f08651ecfd871a794637a0bdbb11cfa74ef]) Merge branch 'tf/LH-24/add-VC8-shipping-define'

    • tf/LH-24/add-VC8-shipping-define: vc8 solution: include shipping preprocessor define

    [#24 state:resolved]

    Signed-off-by: Thell Fowler git@tbfowler.name
    http://github.com/npp-community/npp-community/commit/39947f08651ecf...

    December 7th, 2009 @ 09:15 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.