[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
Reported by Jocelyn Legault | November 25th, 2009 @ 09:35 PM | in v2.0.0
The CheckedOrNot function of some preference dialog is useful
and represents a pattern used in many places and classes in
preferenceDlg.cpp.
We need to:
- Create a base class to all the dialogs in that file that will
implement the CheckedOrNot function - Replace all the places where
the pattern is used, but not through that function.
Comments and changes to this ticket
-
Jocelyn Legault November 25th, 2009 @ 09:59 PM
- State changed from “open” to “needs_ack”
- Assigned user changed from “Jocelyn Legault” to “npp-community”
(from [802040213dfb6f9c87627fa4e53e5c6c2e623d0f]) isCheckedOrNot: generalize the use of this function.
- A new PreferenceDialogBase class has been created and houses the isCheckedOrNot function, so it can be used by all preference dialogs.
- All the lines that were using the "raw" pattern have been replaced.
[#21 state:needs_ack responsible:npp-community]
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/joce/npp-community/commit/802040213dfb6f9c87627fa... -
Thell Fowler November 28th, 2009 @ 08:14 PM
- State changed from “needs_ack” to “acked”
-
npp-community November 29th, 2009 @ 06:35 AM
- State changed from “acked” to “proposed”
(from [5b26677e24491f64fb6338afd6e7fffbb2aff048]) isCheckedOrNot: generalize the use of this function.
- A new PreferenceDialogBase class has been created and houses the isCheckedOrNot function, so it can be used by all preference dialogs.
- All the lines that were using the "raw" pattern have been replaced.
[#21 state:proposed responsible:npp-community]
Acked-by: Thell Fowler git@tbfowler.name
Signed-off-by: Jocelyn Legault jocelynlegault@gmail.com
http://github.com/npp-community/npp-community/commit/5b26677e24491f... -
Thell Fowler December 7th, 2009 @ 06:14 AM
(from [be96abd5368ec86d86e0cfab6f0017cb260758da]) Merge branch 'jl/LH-21/widespread-use-of-CheckedOrNot' into pu
- jl/LH-21/widespread-use-of-CheckedOrNot: isCheckedOrNot: generalize the use of this function.
[#21 state:proposed]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/be96abd5368ec8... -
Thell Fowler December 7th, 2009 @ 09:35 PM
(from [fb6714c08e69a22cc1840c98af3bc3dba40d2274]) Merge branch 'jl/LH-21/widespread-use-of-CheckedOrNot' into pu
- jl/LH-21/widespread-use-of-CheckedOrNot: isCheckedOrNot: generalize the use of this function.
[#21 state:proposed]
Acked-by: Thell Fowler git@tbfowler.name
http://github.com/npp-community/npp-community/commit/fb6714c08e69a2... -
Jocelyn Legault December 14th, 2009 @ 05:09 PM
- Milestone set to “v2.0.0”
-
Thell Fowler December 22nd, 2009 @ 03:53 PM
(from [f25205ec1c2d8f3be3b97620c46f51c30469586f]) Merge branch 'jl/LH-21/widespread-use-of-CheckedOrNot' into pu
- jl/LH-21/widespread-use-of-CheckedOrNot: isCheckedOrNot: generalize the use of this function.
Conflicts:
PowerEditor/src/WinControls/Preference/preferenceDlg.cpp[#21]
Signed-off-by: Thell Fowler git@tbfowler.name
http://github.com/almostautomated/npp-community/commit/f25205ec1c2d... -
Thell Fowler January 19th, 2010 @ 12:06 AM
- State changed from “proposed” to “resolved”
Not sure why the last commit didn't carry over form Github...
Promoted:
http://github.com/npp-community/npp-community/commit/af7976bacce0ed...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Notepad++ Community Release
People watching this ticket
Jocelyn Legault
npp-community
Referenced by
-
21
[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
[#21
state:needs_ack responsible:npp-community]
-
21
[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
[#21
state:proposed responsible:npp-community]
-
21
[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
[#21
state:proposed]
-
21
[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
[#21
state:proposed]
-
21
[improvement] More widespread use of CheckedOrNot in preferenceDlg.cpp
[#21]