[Improvement] Fix Parameters.cpp
Reported by Jocelyn Legault | November 24th, 2009 @ 11:27 PM
Parameters.cpp is one of the most borked files in N++ (along with Notepad_plus.cpp), but clearely the easiest to fix.
Fixes that could be done rather easily:
- Separate the massive chunk that is that file by logical
grouping.
- Add unit testing for each of these groups
- Factorize the horrendous duplication that is the reading and
writing of the different parameters (see
NppParameters::feedGUIParameters,NppParameters::feedScintillaParam,NppParameters::writeGUIParams()and such).
Comments and changes to this ticket
-
Jocelyn Legault November 24th, 2009 @ 11:56 PM
- Tag cleared.
- Title changed from “Fix Parameters.cpp” to “[Improvement] Fix Parameters.cpp”
-
Jocelyn Legault November 25th, 2009 @ 08:21 PM
- Tag set to “parameters, _improvement”
-
Thell Fowler November 29th, 2009 @ 03:21 AM
Yeah, that file is a huge mess. Given that there has been a branch jl/nppcr-Parameters.cpp-overhaul merged onto pu is that to be the starting point for this?
I can rename that branch to jl/LH-17/split-apart-parameters.cpp if that would be helpful at all.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Notepad++ Community Release
People watching this ticket
Jocelyn Legault
Thell Fowler
Tags
Referenced by
-
36
Notepad_plus.cpp: rewrite of menuID2LangType()
Which reminds me that I should fix some of my older broad...