Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

[Improvement] Fix Parameters.cpp

#17

Parameters.cpp is one of the most borked files in N++ (along with Notepad_plus.cpp), but clearely the easiest to fix.

Fixes that could be done rather easily:

  • Separate the massive chunk that is that file by logical grouping.
    • Add unit testing for each of these groups
  • Factorize the horrendous duplication that is the reading and writing of the different parameters (see NppParameters::feedGUIParameters, NppParameters::feedScintillaParam, NppParameters::writeGUIParams() and such).

Reported by Jocelyn Legault · November 24th, 2009 @ 11:27 PM

State: open
Milestone: none
Assigned to: Jocelyn Legault Jocelyn Legault

Activity

  1. Jocelyn Legault
    Jocelyn Legault
    • Tag cleared.
    • Title changed from Fix Parameters.cpp to [Improvement] Fix Parameters.cpp

    November 24th, 2009 @ 11:56 PM

  2. Jocelyn Legault
    Jocelyn Legault
    • Tag set to parameters, _improvement

    November 25th, 2009 @ 08:21 PM

  3. Thell Fowler
    Thell Fowler

    Yeah, that file is a huge mess. Given that there has been a branch jl/nppcr-Parameters.cpp-overhaul merged onto pu is that to be the starting point for this?

    I can rename that branch to jl/LH-17/split-apart-parameters.cpp if that would be helpful at all.

    November 29th, 2009 @ 03:21 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.